1176312 - Listen for 'change' events on the geolocation switch

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Sam Foster [:sfoster] (he/him)]

Similar to bug 1175861, we should listen for 'change' not 'click' events on the gaia-switch controls to ensure we get and write the right state to settings.

Comment 2

[Kevin Grandon :kgrandon]

Thanks for filing this Sam. Did you want to submit a patch for this, or should I take this?

Comment 3

[Sam Foster [:sfoster] (he/him)]

Attachment: PR: Listen for change event on geolocation switch

Had this in the works already, can you review?

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8624844 [details] [review]
PR: Listen for change event on geolocation switch

Thanks!

Comment 5

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/406a2865c3d26ccfc4ba978c506d7758e1b7e131

Comment 6

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on latest Nightly build of Flame v3.0.


STR：
1.Flash build.
2.Enter FTU and go to Geolocation page.
3.Disable/Enable/Disable geolocation.
**The geolocation can be switched to disable/enable successfully.
4.Skip FTU to go to Settings app.
**The geolocation is disabled as expected.

See attachment: verified_v3.0.3gp
Reproduce rate: 0/6

Device: Flame v3.0 build(Verified)
Build ID               20150622160206
Gaia Revision          311c4e59936a407e64509f54fecb440d8a78e3c8
Gaia Date              2015-06-20 20:21:42
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/be81b8d6fae9
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150622.193834
Firmware Date          Mon Jun 22 19:38:45 EDT 2015
Bootloader             L1TC000118D0

Comment 7

[Shally Li（leave from Mozilla）]

Attachment: verified_v3.0.3gp