Closed Bug 1176523 Opened 5 years ago Closed 5 years ago

convert nsTableColFrame and nsTableColGroupFrame to logical coordinates

Categories

(Core :: Layout: Tables, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: jfkthame, Assigned: jfkthame)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
These classes seem to "mostly work" already; the main issue I see remaining is the conversion of {Get,Set}ContinuousBCBorderWidth to work with logical coordinates, like the corresponding methods on rows.
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Oops, missed one callsite; sorry for the churn.
Attachment #8625365 - Flags: review?(dholbert)
Attachment #8625363 - Attachment is obsolete: true
Attachment #8625363 - Flags: review?(dholbert)
Blocks: 1176524
Comment on attachment 8625365 [details] [diff] [review]
Convert Get/SetContinuousBCBorderWidth in nsTableColFrame and nsTableColGroupFrame to logical coordinates

Looks like we've got some calls to "GetContinuousLeftBCBorderWidth" (physically-named -- "left") which are surviving through this patch, e.g.:

>+++ b/layout/tables/nsTablePainter.cpp
>-      border.left = aTableFrame->GetContinuousLeftBCBorderWidth();
>+      border.IStart(wm) = aTableFrame->GetContinuousLeftBCBorderWidth();
[...]
>     //Start with table's left border.
>     nscoord lastLeftBorder = aTableFrame->GetContinuousLeftBCBorderWidth();
[...]
>+        border.IStart(wm) = lastLeftBorder;
>+        cgFrame->GetContinuousBCBorderWidth(wm, border);

This is marginally problematic, since we're using this "physical-left"-flavored quantity in a "logical-istart"-flavored expression.  Not a big deal as long as we eventually fix it; do you know if there's a bug that already covers converting this function?  (You mentioned a larger border-collapse bug I think - maybe this is covered there?)
Right, a lot of border-collapse stuff is still pending (either as additional patches in bug 1157569, or a new bug). Collapsed borders in general are currently very broken in vertical mode. So I've ignored it here.
Comment on attachment 8625365 [details] [diff] [review]
Convert Get/SetContinuousBCBorderWidth in nsTableColFrame and nsTableColGroupFrame to logical coordinates

OK, r=me.
Attachment #8625365 - Flags: review?(dholbert) → review+
https://hg.mozilla.org/mozilla-central/rev/a8fc665d7fab
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.