1176523 - convert nsTableColFrame and nsTableColGroupFrame to logical coordinates

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect)

Comment 1

[Jonathan Kew [:jfkthame]]

These classes seem to "mostly work" already; the main issue I see remaining is the conversion of {Get,Set}ContinuousBCBorderWidth to work with logical coordinates, like the corresponding methods on rows.

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Convert Get/SetContinuousBCBorderWidth in nsTableColFrame and nsTableColGroupFrame to logical coordinates

Comment 3

[Jonathan Kew [:jfkthame]]

Attachment: Convert Get/SetContinuousBCBorderWidth in nsTableColFrame and nsTableColGroupFrame to logical coordinates

Oops, missed one callsite; sorry for the churn.

Comment 4

[Daniel Holbert [:dholbert]]

Comment on attachment 8625365 [details] [diff] [review]
Convert Get/SetContinuousBCBorderWidth in nsTableColFrame and nsTableColGroupFrame to logical coordinates

Looks like we've got some calls to "GetContinuousLeftBCBorderWidth" (physically-named -- "left") which are surviving through this patch, e.g.:

>+++ b/layout/tables/nsTablePainter.cpp
>-      border.left = aTableFrame->GetContinuousLeftBCBorderWidth();
>+      border.IStart(wm) = aTableFrame->GetContinuousLeftBCBorderWidth();
[...]
>     //Start with table's left border.
>     nscoord lastLeftBorder = aTableFrame->GetContinuousLeftBCBorderWidth();
[...]
>+        border.IStart(wm) = lastLeftBorder;
>+        cgFrame->GetContinuousBCBorderWidth(wm, border);

This is marginally problematic, since we're using this "physical-left"-flavored quantity in a "logical-istart"-flavored expression.  Not a big deal as long as we eventually fix it; do you know if there's a bug that already covers converting this function?  (You mentioned a larger border-collapse bug I think - maybe this is covered there?)

Comment 5

[Jonathan Kew [:jfkthame]]

Right, a lot of border-collapse stuff is still pending (either as additional patches in bug 1157569, or a new bug). Collapsed borders in general are currently very broken in vertical mode. So I've ignored it here.

Comment 6

[Daniel Holbert [:dholbert]]

Comment on attachment 8625365 [details] [diff] [review]
Convert Get/SetContinuousBCBorderWidth in nsTableColFrame and nsTableColGroupFrame to logical coordinates

OK, r=me.

Comment 7

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a8fc665d7fab

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a8fc665d7fab