Closed Bug 1077521 Opened 5 years ago Closed Last year

vertical writing mode support for tables

Categories

(Core :: Layout: Tables, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: jfkthame, Assigned: jfkthame)

References

(Depends on 6 open bugs, Blocks 3 open bugs)

Details

(Keywords: css3, intl, testcase)

Attachments

(4 files)

The content of table cells should largely be handled by the general writing-mode support being implemented throughout layout; but the layout of the table as a whole (columns and rows) also needs to be handled. This may be deferred to a later milestone than the initial release of vertical support for "simple" content.
Blocks: 1079125
Layout of content of table cells in vertical writing-mode
---------------------------------------------------------

table-cell and 'vertical-rl' - block flow direction of block-level boxes
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/wm-block-flow-direction-011.xht

table-cell and 'vertical-lr' - block flow direction of block-level boxes
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/wm-block-flow-direction-012.xht



Layout of table as a whole: row progression tests
-------------------------------------------------

vertical-rl - table rows progression (basic)
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/wm-row-progression-002.xht

vertical-lr - table rows progression (basic)
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/wm-row-progression-003.xht

vertical-rl - table rows progression and colspan
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/wm-row-progression-004.xht

vertical-lr - table rows progression and colspan
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/wm-row-progression-005.xht

vertical-rl - table rows progression and rowspan
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/wm-row-progression-006.xht

vertical-lr - table rows progression and rowspan
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/wm-row-progression-007.xht



Those 8 tests all use the same reference file:
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/multicol-count-002-ref.xht
Keywords: css3, intl, testcase
Layout of content of table cells in vertical writing-mode
---------------------------------------------------------

table-cell and 'vertical-rl' - ordering direction of line boxes
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/wm-line-box-direction-011.xht

table-cell and 'vertical-lr' - ordering direction of line boxes
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/wm-line-box-direction-012.xht
Depends on: 1130907
Note that a number of the tests in reftests/writing-mode/ua-style-sheet-* that involve tables currently have their vertical writing-mode portions commented out. We should uncomment these once vertical layout is supported.
Depends on: 1145036
Firefox (4/22/2015 Aurora) seems to have the same bug in tables that Chrome has, namely cell content overflows when children of cells are given a vertical writing-mode.

See https://code.google.com/p/chromium/issues/detail?id=410320 for a description of the bug and testcase showing the error.
Depends on: 1157569
Blocks: 1132308
Depends on: 1159101
Depends on: 1159990
Depends on: 1165168
Depends on: 1165172
Depends on: 1165797
Quick draft test on orthogonal table cell based on latest comments 94 and 95 in bug 145503 and also based on 
[CSSWG] Minutes New York F2F 2015-05-19 Part I: Writing Modes: Deferring Orthogonal Table Cells
http://lists.w3.org/Archives/Public/www-style/2015May/0313.html

http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/s73-orthogonal-table-cell-003.xht

This test is, I guess, okay, acceptable for now; its filename may change in the future.

When I have done more orthogonal table-cell tests and when such orthogonal table-cell tests are more reliable and mature, then I will create another bug report and I will make it blocking this bug 1077521.

Gérard
(In reply to Tyler Rasmussen from comment #4)
> Firefox (4/22/2015 Aurora) seems to have the same bug in tables that Chrome
> has, namely cell content overflows when children of cells are given a
> vertical writing-mode.

When I have more time, I will create tests based on your description. This whole thing is still *very tricky* as
- browsers have quirks and many bugs on table cell rendering
- overflow applies to non-replaced table cells, including overflow: visible
Depends on: 1171328
Depends on: 1173305
Depends on: 1173307
(In reply to Gérard Talbot from comment #6)
> (In reply to Tyler Rasmussen from comment #4)
> > Firefox (4/22/2015 Aurora) seems to have the same bug in tables that Chrome
> > has, namely cell content overflows when children of cells are given a
> > vertical writing-mode.
> 
> When I have more time, I will create tests based on your description. This
> whole thing is still *very tricky* as
> - browsers have quirks and many bugs on table cell rendering
> - overflow applies to non-replaced table cells, including overflow: visible

This issue is in bug 1166120.
Depends on: 1173958
Depends on: 1174504
Depends on: 1174700
Depends on: 1174711
Depends on: 1175859
Depends on: 1176523
Depends on: 1176524
Just for your information. These 2 tests

table-cell and 'vertical-rl' - ordering direction of line boxes
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/wm-line-box-direction-011.xht
 
table-cell and 'vertical-lr' - ordering direction of line boxes
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/wm-line-box-direction-012.xht

now pass in Firefox latest nightly build (41.0a1 buildID = 20150622052959).

Gérard
Maybe it's time to do this... table support is some way from complete yet, but I think there's enough of it that we can usefully turn it on and start adding tests, and we don't need this "protecting" us any longer.
Attachment #8625462 - Flags: review?(smontagu)
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Comment on attachment 8625462 [details] [diff] [review]
Allow tables to use vertical writing modes

Review of attachment 8625462 [details] [diff] [review]:
-----------------------------------------------------------------

Totally!
Attachment #8625462 - Flags: review?(smontagu) → review+
Here are a couple of basic sanity-test reftests for vertical table layout. Obviously there'll be more to come...
Attachment #8625479 - Flags: review?(smontagu)
Attachment #8625479 - Flags: review?(smontagu) → review+
More testcases.
Attachment #8625498 - Flags: review?(smontagu)
Attachment #8625499 - Flags: review?(smontagu)
Pushed the CSS change and initial reftests here, but let's keep the bug open for at least a few more testcase before marking it fixed.
Keywords: leave-open
Attachment #8625498 - Flags: review?(smontagu) → review+
Depends on: 1177076
Depends on: 1177600
Depends on: 1177606
Attachment #8625499 - Flags: review?(smontagu) → review+
Depends on: 1178250
Depends on: 1179741
Depends on: 1177690
Depends on: 1180528
Depends on: 1185430
Depends on: 1193145
Depends on: 1202993
Depends on: 1227616
Depends on: 1259168
Depends on: 1468291
The leave-open keyword is there and there is no activity for 6 months.
:jfkthame, maybe it's time to close this bug?
Flags: needinfo?(jfkthame)
I guess we can close this, as the feature is basically working; and make the remaining open dependencies here directly block the main writing-mode meta bug.
Status: ASSIGNED → RESOLVED
Closed: Last year
Flags: needinfo?(jfkthame)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.