Closed Bug 1176533 Opened 5 years ago Closed 5 years ago

Rename the *VERSION_ABOUT to *VERSION_DISPLAY variable

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox41 fixed, firefox42 fixed)

RESOLVED FIXED
mozilla42
Tracking Status
firefox41 --- fixed
firefox42 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

Details

Attachments

(1 file)

As it is going to be used also for the support page (cf bug 1145171), I would like to rename the variable for something more general.
Attachment #8625096 - Flags: review?(mh+mozilla)
Attachment #8625096 - Flags: review?(mh+mozilla) → review+
Assignee: nobody → sledru
Blocks: 1145175
Depends on: 1145171
https://hg.mozilla.org/mozilla-central/rev/e740662a0363
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Comment on attachment 8625096 [details] [diff] [review]
rename-version-about.diff

Approval Request Comment
[Feature/regressing bug #]: bug 1145184 - getting the beta information more available
[User impact if declined]: a few weeks more without the beta information available in about:support. This patch is just a basic renaming necessary for the uplift of bug 1145171
[Describe test coverage new/current, TreeHerder]: in m-c + https://treeherder.mozilla.org/#/jobs?repo=try&revision=c6a6d6bbbaf1 in inbound. 
[Risks and why]: Low risk as we are just renaming some variables. Worst case scenario is that the version information will be empty in the window.
[String/UUID change made/needed]: None
Attachment #8625096 - Flags: approval-mozilla-aurora?
Comment on attachment 8625096 [details] [diff] [review]
rename-version-about.diff

Approved. It would be nice to see "real" beta versions in about:support.
Attachment #8625096 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
See Also: → 1343585
Component: Build Config → General
Product: Firefox → Firefox Build System
Target Milestone: Firefox 42 → mozilla42
You need to log in before you can comment on or make changes to this bug.