Closed
Bug 1176533
Opened 9 years ago
Closed 9 years ago
Rename the *VERSION_ABOUT to *VERSION_DISPLAY variable
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox41 fixed, firefox42 fixed)
RESOLVED
FIXED
mozilla42
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
Details
Attachments
(1 file)
|
13.55 KB,
patch
|
glandium
:
review+
ritu
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
As it is going to be used also for the support page (cf bug 1145171), I would like to rename the variable for something more general.
Attachment #8625096 -
Flags: review?(mh+mozilla)
|
||
Updated•9 years ago
|
Attachment #8625096 -
Flags: review?(mh+mozilla) → review+
|
Assignee | |
Comment 1•9 years ago
|
||
|
||
Comment 2•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
|
|
Assignee | |
Comment 3•9 years ago
|
||
Comment on attachment 8625096 [details] [diff] [review]
rename-version-about.diff
Approval Request Comment
[Feature/regressing bug #]: bug 1145184 - getting the beta information more available
[User impact if declined]: a few weeks more without the beta information available in about:support. This patch is just a basic renaming necessary for the uplift of bug 1145171
[Describe test coverage new/current, TreeHerder]: in m-c + https://treeherder.mozilla.org/#/jobs?repo=try&revision=c6a6d6bbbaf1 in inbound.
[Risks and why]: Low risk as we are just renaming some variables. Worst case scenario is that the version information will be empty in the window.
[String/UUID change made/needed]: None
Attachment #8625096 -
Flags: approval-mozilla-aurora?
Comment on attachment 8625096 [details] [diff] [review]
rename-version-about.diff
Approved. It would be nice to see "real" beta versions in about:support.
Attachment #8625096 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
|
||
Comment 5•9 years ago
|
||
|
||
Updated•6 years ago
|
Component: Build Config → General
Product: Firefox → Firefox Build System
|
||
Updated•6 years ago
|
Target Milestone: Firefox 42 → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•