Include the beta version in about:support

RESOLVED FIXED in Firefox 41

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: sylvestre, Assigned: sylvestre)

Tracking

(Blocks 1 bug)

unspecified
mozilla42
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox41 fixed, firefox42 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

In the release management process (and also for QE and UA), having the beta number displayed in about:support would help a lot.

The buildid is a too technical information for most of our users (and, usually, even us, we sometimes don't know).
No longer depends on: 638769
Does the beta number get baked into the build?
Duplicate of this bug: 1175152
Blocks: 1145184
No longer depends on: 1145184
Comment on attachment 8623607 [details] [diff] [review]
betasupport.diff

Review of attachment 8623607 [details] [diff] [review]:
-----------------------------------------------------------------

This patch requires to |hg add browser/config/version_about.txt| after copying from version.txt. Setting its content to 39.0b6 throws a config error.

Furthermore, this patch has been bitrotted by a AppConstants.jsm refactoring.
Thanks for the feedback but this is an ongoing work. That is why I didn't ask for a review yet. :)
Assignee: nobody → sledru
Posted patch aboutsupport.diff (obsolete) — Splinter Review
Should be fine now
Attachment #8623607 - Attachment is obsolete: true
Archaeopteryx, what was the error you had?
It is not clear who can review that... Maybe you can (or help me).
Attachment #8625095 - Attachment is obsolete: true
Attachment #8625961 - Flags: review?(dolske)
Comment on attachment 8625961 [details] [diff] [review]
aboutsupport.diff

Review of attachment 8625961 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/modules/Troubleshoot.jsm
@@ +171,5 @@
>  
>    application: function application(done) {
>      let data = {
>        name: Services.appinfo.name,
> +      version: AppConstants.MOZ_APP_VERSION_ABOUT,

The data gets exposed to certain Mozilla sites (see bug 1079563), have you checked with who's currently using this to make sure getting the extra version info isn't going to break anything? If so, r+.
Attachment #8625961 - Flags: review?(dolske) → review+
I started a try job to confirm that:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c6a6d6bbbaf1

Mark, do you see any potential issue with this change? thanks
Flags: needinfo?(markh)
remote troubleshooting means sumo could potentially/surprisingly be affected, but I don't see any in-tree issues.
Flags: needinfo?(markh)
https://hg.mozilla.org/mozilla-central/rev/f629ea0eb5b1
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Comment on attachment 8625961 [details] [diff] [review]
aboutsupport.diff

Approval Request Comment
[Feature/regressing bug #]: bug 1145184 - getting the beta information more available
[User impact if declined]: a few weeks more without the beta information available in about:support. This patch depends on bug 1145171
[Describe test coverage new/current, TreeHerder]: in m-c + https://treeherder.mozilla.org/#/jobs?repo=try&revision=c6a6d6bbbaf1 in inbound. 
[Risks and why]: Should be low risk. However, this might have an impact on sumo as Mark mentioned. This will only be a potential issue when 41 moves to beta.
[String/UUID change made/needed]: None
Attachment #8625961 - Flags: approval-mozilla-aurora?
Comment on attachment 8625961 [details] [diff] [review]
aboutsupport.diff

Let's land this in Aurora. Try server results look good, should be safe.
Attachment #8625961 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.