1145171 - Include the beta version in about:support

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

In the release management process (and also for QE and UA), having the beta number displayed in about:support would help a lot.

The buildid is a too technical information for most of our users (and, usually, even us, we sometimes don't know).

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Does the beta number get baked into the build?

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Attachment: betasupport.diff

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Comment on attachment 8623607 [details] [diff] [review]
betasupport.diff

Review of attachment 8623607 [details] [diff] [review]:
-----------------------------------------------------------------

This patch requires to |hg add browser/config/version_about.txt| after copying from version.txt. Setting its content to 39.0b6 throws a config error.

Furthermore, this patch has been bitrotted by a AppConstants.jsm refactoring.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Thanks for the feedback but this is an ongoing work. That is why I didn't ask for a review yet. :)

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Attachment: aboutsupport.diff

Should be fine now

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Archaeopteryx, what was the error you had?

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Attachment: aboutsupport.diff

It is not clear who can review that... Maybe you can (or help me).

Comment 9

[Justin Dolske [:Dolske]]

Comment on attachment 8625961 [details] [diff] [review]
aboutsupport.diff

Review of attachment 8625961 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/modules/Troubleshoot.jsm
@@ +171,5 @@
>  
>    application: function application(done) {
>      let data = {
>        name: Services.appinfo.name,
> +      version: AppConstants.MOZ_APP_VERSION_ABOUT,

The data gets exposed to certain Mozilla sites (see bug 1079563), have you checked with who's currently using this to make sure getting the extra version info isn't going to break anything? If so, r+.

Comment 10

[Sylvestre Ledru [:Sylvestre]]

I started a try job to confirm that:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c6a6d6bbbaf1

Mark, do you see any potential issue with this change? thanks

Comment 11

[Mark Hammond [:markh] [:mhammond]]

remote troubleshooting means sumo could potentially/surprisingly be affected, but I don't see any in-tree issues.

Comment 12

[Sylvestre Ledru [:Sylvestre]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f629ea0eb5b1

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f629ea0eb5b1

Comment 14

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8625961 [details] [diff] [review]
aboutsupport.diff

Approval Request Comment
[Feature/regressing bug #]: bug 1145184 - getting the beta information more available
[User impact if declined]: a few weeks more without the beta information available in about:support. This patch depends on bug 1145171
[Describe test coverage new/current, TreeHerder]: in m-c + https://treeherder.mozilla.org/#/jobs?repo=try&revision=c6a6d6bbbaf1 in inbound. 
[Risks and why]: Should be low risk. However, this might have an impact on sumo as Mark mentioned. This will only be a potential issue when 41 moves to beta.
[String/UUID change made/needed]: None

Comment 15

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8625961 [details] [diff] [review]
aboutsupport.diff

Let's land this in Aurora. Try server results look good, should be safe.

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d54724498db0