Closed
Bug 1176657
Opened 10 years ago
Closed 10 years ago
[Contacts][NGA] Remove Contacts.confirmDialog from import_from_vcard.js
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(b2g-master fixed)
RESOLVED
FIXED
FxOS-S1 (26Jun)
| Tracking | Status | |
|---|---|---|
| b2g-master | --- | fixed |
People
(Reporter: jorgep, Assigned: mancas)
References
Details
(Whiteboard: [NG Gaia Contacts][patch])
Attachments
(1 file)
confirmDialog() function doesn't exist on Contacts.js class and its functionality was moved to ConfirmDialog class.
We should change Contacts.confirmDialog() by ConfirmDialog.show().
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8625249 -
Flags: review?(francisco)
|
Reporter | |
Updated•10 years ago
|
Attachment #8625249 -
Flags: review?(francisco)
Attachment #8625249 -
Flags: review?(borja.bugzilla)
|
|
||
Updated•10 years ago
|
Attachment #8625249 -
Flags: review?(borja.bugzilla) → review+
|
||
Updated•10 years ago
|
Whiteboard: [NG Gaia Contacts] → [NG Gaia Contacts][patch]
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8625249 [details] [review]
Contacts.confirmDialog removed
Good catch. LGTM.
Attachment #8625249 -
Flags: review?(francisco) → review+
|
|
||
Comment 3•10 years ago
|
||
Relaunched unit tests, once they are gree we are ready to land.
|
|
||
Updated•10 years ago
|
Keywords: checkin-needed
|
|
||
Comment 4•10 years ago
|
||
|
|
||
Updated•10 years ago
|
status-b2g-master:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•