[Contacts][NGA] Remove Contacts.confirmDialog from import_from_vcard.js

RESOLVED FIXED in Firefox OS master

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jorgep, Assigned: mancas)

Tracking

unspecified
FxOS-S1 (26Jun)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(b2g-master fixed)

Details

(Whiteboard: [NG Gaia Contacts][patch])

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
confirmDialog() function doesn't exist on Contacts.js class and its functionality was moved to ConfirmDialog class.

We should change Contacts.confirmDialog() by ConfirmDialog.show().
(Assignee)

Comment 1

3 years ago
Created attachment 8625249 [details] [review]
Contacts.confirmDialog removed
Attachment #8625249 - Flags: review?(francisco)
(Reporter)

Updated

3 years ago
Attachment #8625249 - Flags: review?(francisco)
Attachment #8625249 - Flags: review?(borja.bugzilla)
Attachment #8625249 - Flags: review?(borja.bugzilla) → review+
Whiteboard: [NG Gaia Contacts] → [NG Gaia Contacts][patch]
Comment on attachment 8625249 [details] [review]
Contacts.confirmDialog removed

Good catch. LGTM.
Attachment #8625249 - Flags: review?(francisco) → review+
Relaunched unit tests, once they are gree we are ready to land.
(Assignee)

Updated

3 years ago
Blocks: 1177662
(Assignee)

Updated

3 years ago
No longer blocks: 1177662
Keywords: checkin-needed
https://github.com/mozilla-b2g/gaia/commit/481fba7b10dfdebcec6807170c0257a527c174cf
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
status-b2g-master: --- → fixed
You need to log in before you can comment on or make changes to this bug.