1176959 - [e10s][GTK] Kakutei-Undo of Mozc doesn't work

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

1. Install Mozc
2. Commit something
3. Ctrl + Backspace

Actual Result:

Starts new composition after committed string (IIRC)

Expected result:

Remove the committed string and restart composition.

# Could be dup of bug 1176955 but not sure yet.

Comment 1

[Makoto Kato [:m_kato]]

OnSelectionChanged is called?  Then ResetIME will remove composition.

Comment 2

[Makoto Kato [:m_kato]]

This is 2 issues.

- Selection is invalid by bug 1175392, DeleteText always return failure.
- Even if fixing bug 1178652, since set selection is async, mIsDeletingSurrounding is false.  It means OnSelectionChange will call ResetIME, then composition is reset.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

Same as TSF, we shouldn't notify IME of selection change which was requested by IME on GTK too.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8634008 [details] [diff] [review]
Patch

We can fix this bug with same approach as bug 1176955.

Comment 5

[Makoto Kato [:m_kato]]

Comment on attachment 8634008 [details] [diff] [review]
Patch

Review of attachment 8634008 [details] [diff] [review]:
-----------------------------------------------------------------

nsGtkIMModule::DeleteText posts several content queries, but NS_CONTENT_COMMAND_DELETE will causes selection change on non-e10s mode.

So, we cannot remove mIsDeletingSurrounding even if applying this fix...  So it is OK.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

> nsGtkIMModule::DeleteText posts several content queries, but NS_CONTENT_COMMAND_DELETE will
> causes selection change on non-e10s mode.

Ah, good point. I guess we should mark it as caused by content command or something.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/82af92db4420e296e6249fa4c305a9417cc382e3
changeset:  82af92db4420e296e6249fa4c305a9417cc382e3
user:       Masayuki Nakano <[e-mail]>
date:       Fri Jul 17 13:27:32 2015 +0900
description:
Bug 1176959 nsGtkIMModule shouldn't commit composition when a selection change is notified but it was caused by selection set event r=m_kato

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/82af92db4420