1177244 - [Linter: MergeRootFrame] Use <merge> instead of <FrameLayout> where applicable

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

via android lint:

MergeRootFrame: FrameLayout can be replaced with <merge> tag
../../src/main/res/layout/overlay_share_dialog.xml:8: This <FrameLayout> can be replaced with a <merge> tag

   5    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
   6 
   7 <!-- Serves to position the content on the screen (bottom, centered) and provide the drop-shadow -->
   8 <FrameLayout
   9     xmlns:android="http://schemas.android.com/apk/res/android"
  10     xmlns:gecko="http://schemas.android.com/apk/res-auto"

../../src/main/res/layout/tab_queue_prompt.xml:7: This <FrameLayout> can be replaced with a <merge> tag

   4    - License, v. 2.0. If a copy of the MPL was not distributed with this
   5    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
   6 
   7 <FrameLayout
   8     xmlns:android="http://schemas.android.com/apk/res/android"
   9     xmlns:tools="http://schemas.android.com/tools"

Priority: 4 / 10
Category: Performance
Severity: Warning
Explanation: FrameLayout can be replaced with <merge> tag.
If a <FrameLayout> is the root of a layout and does not provide background or padding etc, it can often be replaced with a <merge> tag which is slightly more efficient. Note that this depends on context, so make sure you understand how the <merge> tag works before proceeding.

More info: http://android-developers.blogspot.com/2009/03/android-layout-tricks-3-optimize-by.html

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1177244 - Move share dialog to merge tag. r=mhaigh

Bug 1177244 - Move share dialog to merge tag. r=mhaigh

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1177244 - Move tab queue prompt to merge tag. r=mhaigh

Bug 1177244 - Move tab queue prompt to merge tag. r=mhaigh

Comment 3

[Martyn Haigh (:mhaigh)]

Comment on attachment 8625934 [details]
MozReview Request: Bug 1177244 - Move share dialog to merge tag. r=mhaigh

https://reviewboard.mozilla.org/r/11949/#review10527

Comment 4

[Martyn Haigh (:mhaigh)]

Comment on attachment 8625935 [details]
MozReview Request: Bug 1177244 - Move tab queue prompt to merge tag. r=mhaigh

https://reviewboard.mozilla.org/r/11951/#review10529

Ship It!

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/abb76da74283
https://hg.mozilla.org/integration/fx-team/rev/f5406c0ff694

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/99e103cb3352

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/abb76da74283
https://hg.mozilla.org/mozilla-central/rev/f5406c0ff694
https://hg.mozilla.org/mozilla-central/rev/99e103cb3352