1177338 - Find bar persists on about:home, overlaps search engine buttons

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

On a nexus 4 with latest nightly:
1) open a page (e.g. this bugzilla page)
2) select the find in page menu item
3) while the find bar (and vkb) are onscreen, open the tab switcher and open a new tab

expected: new tab opens to about:home and find bar is dismissed

Actual: find bar sticks around. If you then put focus in the url bar and start typing things get worse because the search engine icons at the bottom of the screen overlap the find bar and it looks really bad.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

We handled this on the search screen in bug 1175434 but you're right that we should really be doing this on about:home.

Sebastian?

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Looking into it!

Comment 3

[Kevin Brosnan [Ex-Mozilla]]

Is this a dupe of bug 1175434?

Comment 4

[Kevin Brosnan [Ex-Mozilla]]

Oops just read comment 1.

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1177338 - Hide "Find in page" bar when tabs panel is displayed. r?mcomella

Bug 1177338 - Hide "Find in page" bar when tabs panel is displayed. r?mcomella

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

This patch hides the "find in page" bar as soon as we open the tabs panel. I feel like there might be more situations where we want to explicitly hide the "find in page" bar. Before we started patching this the "find in page" bar was only dismissed after pressing back or the close button.

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to :Sebastian Kaspari from comment #6)
> This patch hides the "find in page" bar as soon as we open the tabs panel. I
> feel like there might be more situations where we want to explicitly hide
> the "find in page" bar. Before we started patching this the "find in page"
> bar was only dismissed after pressing back or the close button.

It'd be nice if we had a modal system (e.g. BROWSING, EDITING, TAB_TRAY) so that this pretty much *just worked*, but I imagine that'd take more heavy lifting than we'd like. :)

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8626554 [details]
MozReview Request: Bug 1177338 - Hide "Find in page" bar when tabs panel is displayed. r?mcomella

https://reviewboard.mozilla.org/r/12101/#review10909

Ship It!

Comment 9

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Michael Comella (:mcomella) from comment #7)
> It'd be nice if we had a modal system (e.g. BROWSING, EDITING, TAB_TRAY) so
> that this pretty much *just worked*, but I imagine that'd take more heavy
> lifting than we'd like. :)

Something like ... fragments? ;)

Comment 10

[Sebastian Kaspari (:sebastian; :pocmo)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=12a644dc559b

Comment 11

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/967175e283d0

Comment 12

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/967175e283d0