1177472 - Add option to Tab Queue toast to open URL in a private tab

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect, P5)

Description

[(No longer employed by Mozilla) Aaron Klotz]

Just as the summary sounds: I think that it would be useful to have an option in
the tab queue toast to choose to open the link in a private tab.

Comment 1

[Nick Alexander :nalexander [he/him] (PTO August 22-September 12)]

antlam and mhaigh are the most likely to have an informed opinion.

Comment 2

[:Margaret Leibovic]

See also bug 1065004, which is a different approach to addressing this concern, but too much of a hammer IMO.

We definitely have been talking about this already, but I'm not sure what the UX would look like. ally, have you filed a bug about this already?

Comment 3

[Allison Naaktgeboren :ally]

After talking with product, we're going to honor long tap to show a toast with an option to in private or regular browsing. I don't have a bug on file yet but will shortly. I'll update this bug once I have. 

roughly the flow would be 
	- flow is thus
		- setting: open external links in private browsing, default off (already in under nightly flag)
		- setting: open internal links in private browsing, default off (add)
			- possible it might be better to combine them into one pref
		- user goes into settings, checks (1?2?) prefs
		- user clicks on link in ffx
			- tab queue checks internal links pref for private||regular browsing
			- open now in toast opens in browsing mode pointed to by internal links pref
		- user clicks on link in twitter
			- tab queue checks external links pref for private||regular browsing
			- open now in toast opens in browsing mode pointed to by external links pref
		- user long taps
			- present toast menu w/ open in private || open in regular

Comment 4

[:Margaret Leibovic]

(In reply to Allison Naaktgeboren please NEEDINFO? :ally from comment #3)
> After talking with product, we're going to honor long tap to show a toast
> with an option to in private or regular browsing. I don't have a bug on file
> yet but will shortly. I'll update this bug once I have. 

I'm a bit confused about what you mean by long tap here... when you're in another app, we don't have the ability to differentiate between a long tap and a short tap, we can only handle the intent that's launched when you make a short tap.

> roughly the flow would be 
> 	- flow is thus
> 		- setting: open external links in private browsing, default off (already
> in under nightly flag)

I think we should remove this pref in favor of some UX that lets you decide on the fly whether you want to open things in a private tab or a normal tab. We should talk to Anthony to see what he thinks about this.

> 		- setting: open internal links in private browsing, default off (add)
> 			- possible it might be better to combine them into one pref

I definitely don't think we should add another new pref for this. When you're browsing in the browser, you already have the context menu option to open links in a new private tab.

Comment 5

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to :Margaret Leibovic from comment #4)
> I think we should remove this pref in favor of some UX that lets you decide
> on the fly whether you want to open things in a private tab or a normal tab.
> We should talk to Anthony to see what he thinks about this.

My thinking here is that we should have one or the other - any more options would start to be a bit much. I assume we are talking ONLY about links queued with "Open in Background" here? If so, this does align with some of the "richer toasts/notification" ideas we talked about.

I think mhaigh already filed bug 1177423 to track some of that work.

> > 		- setting: open internal links in private browsing, default off (add)
> > 			- possible it might be better to combine them into one pref
> 
> I definitely don't think we should add another new pref for this. When
> you're browsing in the browser, you already have the context menu option to
> open links in a new private tab.

I agree, this shouldn't justify adding another pref right now. 

For users already in Firefox, there is a long-press intent designed to handle this. For those users already using "Open in Background", they can also turn on "Open external links in PB", and for those not using "Open in Background", they can simply use "Open external links in PB".

Comment 6

[Martyn Haigh (:mhaigh)]

I agree with antlam on this - adding more options to that toast in the current form makes it too difficult to use as it's only onscreen for a few seconds.

Comment 7

[Allison Naaktgeboren :ally]

Anthony, if we can't have another pref, or expand the toast for another option, what is your proposal for addressing Karen's product needs here? Namely that opening a in something other than the user's default mode?

Comment 8

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

I'm going to NI Kar here to clear up the ask, it's a bit unclear to me and there are a couple bugs about this pref flying around.

Kar, could you clear it up for me please?

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Please don't limit ourselves to using the Toast as a way to add more functionality. Pocket uses multiple circles instead of a toast. Each circle is an action.

I think of TabQueues as the "right-click menu of native apps" in that Firefox already has a context menu with many actions when used in web content. TabQueues extends this pattern to the native world. We should be able to add actions to the system.

If we decide to have "Open" and Open Privately" in the TabQueue system, I'm sure we can move beyond toasts.

Yes, we can also add "Open" and "Open Privately" actions to the System Notification too.

Comment 10

[Karen Rudnitski [:kar]]

The user story we're ultimately trying to satisfy is: As a user, if I'm in a non-browser application and tap on a URL link, I want to have the option to open it in a Private Browsing session because I'm unsure whether I want that link populating my history (it may not be a totally trustworthy source or I may be embarrassed to have it pop up in my history). 

Acceptance criteria: provide a way for a user to open an external link [a link from outside of the browser] in a Private Browsing session or a normal session.

I'm not limited to how it is ultimately implemented, but the above user story is what we're trying to satisfy here for non-wizards.

Comment 11

[Karl Dubost💡 :karlcow]

Thread related to this
https://groups.google.com/forum/#!topic/mozilla.dev.platform/fmJ1UEENbfM

Comment 12

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 13

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.