Closed Bug 1177523 Opened 5 years ago Closed 5 years ago
Test Layers Acceleration in runtime sanity test
The current runtime test only tests for media hardware decoding. Extend the test to test for layers acceleration.
From IRL, don't ever restart firefox to enable / disable layers acceleration. Just test the pixels in this version.
Comment on attachment 8626385 [details] [diff] [review] Test layers acceleration in runtime sanity test Review of attachment 8626385 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/gfx/SanityTest.js @@ +29,5 @@ > const SNAPSHOT_OK=0; > const SNAPSHOT_INCORRECT=1; > const SNAPSHOT_ERROR=2; > const SNAPSHOT_TIMEOUT=3; > +const SNAPSHOT_VIDEO_OK=4; This makes the existing data trickier to interpret. Can we just rename SNAPSHOT_OK to SNAPSHOT_VIDEO_OK and SNAPSHOT_INCORRECT to SNAPSHOT_VIDEO_FAIL and keep their previous values?
Attachment #8626385 - Flags: review?(dvander) → review+
Carrying r+, updated with feedback from comment 4.
Comment on attachment 8627341 [details] [diff] [review] Test layers acceleration in runtime sanity test Approval Request Comment [Feature/regressing bug #]: Bug 1156135, gfx runtime sanity test. This patch tests layer acceleration in addition to the existing media hardware decoding. [User impact if declined]: None, but we need this for graphics to gather data on start up crashes and if we can use hardware accelerated layers. [Describe test coverage new/current, TreeHerder]: Manual testing. [Risks and why]: Low - We just read more pixels than we currently do, but the test is the same. [String/UUID change made/needed]: None.
Attachment #8627341 - Flags: approval-mozilla-aurora?
Hi Ritu, I pinged in #releng and was told to ping you. Can you please see if we can approve this patch in comment 8? Thanks!
Comment on attachment 8627341 [details] [diff] [review] Test layers acceleration in runtime sanity test Approving uplift to Aurora as this change has been in mozilla-central for a week without any negative impact that we know of. Also the patch seems to mostly test graphics related settings and does not change the functional behavior.
Attachment #8627341 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.