1177523 - Test Layers Acceleration in runtime sanity test

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Mason Chang [Inactive] [:mchang]]

The current runtime test only tests for media hardware decoding. Extend the test to test for layers acceleration.

Comment 1

[Mason Chang [Inactive] [:mchang]]

Attachment: Test layers acceleration

Comment 2

[Mason Chang [Inactive] [:mchang]]

Attachment: Test layers acceleration

Comment 3

[Mason Chang [Inactive] [:mchang]]

Attachment: Test layers acceleration in runtime sanity test

From IRL, don't ever restart firefox to enable / disable layers acceleration. Just test the pixels in this version.

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8626385 [details] [diff] [review]
Test layers acceleration in runtime sanity test

Review of attachment 8626385 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/gfx/SanityTest.js
@@ +29,5 @@
>  const SNAPSHOT_OK=0;
>  const SNAPSHOT_INCORRECT=1;
>  const SNAPSHOT_ERROR=2;
>  const SNAPSHOT_TIMEOUT=3;
> +const SNAPSHOT_VIDEO_OK=4;

This makes the existing data trickier to interpret. Can we just rename SNAPSHOT_OK to SNAPSHOT_VIDEO_OK and SNAPSHOT_INCORRECT to SNAPSHOT_VIDEO_FAIL and keep their previous values?

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/34708d81fff9

Comment 6

[Mason Chang [Inactive] [:mchang]]

Attachment: Test layers acceleration in runtime sanity test

Carrying r+, updated with feedback from comment 4.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/34708d81fff9

Comment 8

[Mason Chang [Inactive] [:mchang]]

Comment on attachment 8627341 [details] [diff] [review]
Test layers acceleration in runtime sanity test

Approval Request Comment
[Feature/regressing bug #]: Bug 1156135, gfx runtime sanity test. This patch tests layer acceleration in addition to the existing media hardware decoding.
[User impact if declined]: None, but we need this for graphics to gather data on start up crashes and if we can use hardware accelerated layers.
[Describe test coverage new/current, TreeHerder]: Manual testing.
[Risks and why]: Low - We just read more pixels than we currently do, but the test is the same. 
[String/UUID change made/needed]: None.

Comment 9

[Mason Chang [Inactive] [:mchang]]

Hi Ritu, I pinged in #releng and was told to ping you. Can you please see if we can approve this patch in comment 8? Thanks!

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8627341 [details] [diff] [review]
Test layers acceleration in runtime sanity test

Approving uplift to Aurora as this change has been in mozilla-central for a week without any negative impact that we know of. Also the patch seems to mostly test graphics related settings and does not change the functional behavior.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/24a20781fe0b