Closed
Bug 1177552
Opened 9 years ago
Closed 9 years ago
remove the variable substitution in build/automation.py.inc
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(firefox41 affected)
RESOLVED
WONTFIX
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | affected |
People
(Reporter: parkouss, Assigned: parkouss)
References
Details
Attachments
(1 file)
|
MozReview Request: Bug 1177552 - remove the variable substitution in build/automation.py.inc. r?ahal
40 bytes,
text/x-review-board-request
|
Details |
So this file is preprocessed during one build phase, and it makes reading/editing this file quite difficult. Well I don't want to make something perfect for now here - The goal is to remove this file anyway, so simply reducing the scope of the preprocessing is good enough for now. :)
|
Assignee | |
Comment 1•9 years ago
|
||
Bug 1177552 - remove the variable substitution in build/automation.py.inc. r?ahal
Attachment #8626403 -
Flags: review?(ahalberstadt)
|
|
Assignee | |
Comment 2•9 years ago
|
||
Pushed to try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ba618ea0545d
|
|
Assignee | |
Comment 3•9 years ago
|
||
Hm, all broken - it seems that I missed a few others Makefile.in and .mk files. I will step back here for now. It won't make a big difference for the goal of removing automation.py.in, so I will just keep the substitution for now.
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8626403 -
Flags: review?(ahalberstadt)
|
||
Comment 4•9 years ago
|
||
I don't think it's worthwhile to try to clean up automation.py, we should just focus on removing the remaining callers so we can remove it.
|
|
Assignee | |
Comment 5•9 years ago
|
||
Yep, agreed.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•