Closed Bug 1177545 Opened 6 years ago Closed 1 year ago

Merge what's left of automation.py.in into remoteautomation.py, remove automation-build.mk

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox41 wontfix, firefox76 fixed)

RESOLVED FIXED
mozilla76
Tracking Status
firefox41 --- wontfix
firefox76 --- fixed

People

(Reporter: parkouss, Assigned: gbrown)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files)

The build/automation.py.inc file is quite a mess, and we should remove the need for it, if possible. :) This is blocking for mochitest for example as we would like to package it properly.

So, quite some work to do - these are the dependencies:

https://dxr.mozilla.org/mozilla-central/search?q=%22from+automation%22&case=true

I propose to make this bug a tracking bug, so we can do the job step by step.
Depends on: 1177552
Depends on: 1177780
Blocks: 1178158
bug 775756 was tracking this overarching work.
So, do you want to mark this bug as blocking bug 775756, or close this as WONTFIX or DUPLICATE ?
It's up to you. Removing automation.py.in is definitely something we want, but I'd also rather have bugs on file to fix the specific issues with it rather than just a generic "remove it" bug.
This is being used as a tracking bug, which I think is arguably a prerequisite to bug 775756, so marking this as blocking.
Blocks: 775756
We removed all uses of automation.py from desktop automation. It's still used in mobile automation, but fixing that is a fair amount of work. We can simplify some build system gunk by just moving the contents of automation.py.in into remoteautomation.py  since we no longer need the preprocessor interpolation.
Blocks: nomakefiles
Component: Mozbase → Build Config
Product: Testing → Core
Summary: clean automation.py.inc and hopefully remove it → Merge what's left of automation.py.in into remoteautomation.py, remove automation-build.mk
Product: Core → Firefox Build System

As far as I can tell, some or all of automation.py.in is dead code. Automation.runApp is definitely dead, and if you remove that a lot of other code can be removed too.

Here's a try push where I added a raise Exception("blah") to the start of runApp, and it appears to have run just fine: https://treeherder.mozilla.org/#/jobs?repo=try&revision=17c835c2a31e9a6519c9ed9b102a4edf63df8e74

Thanks! I'll see if I can move this forward.

Assignee: nobody → gbrown

Remove unused code from automation.py.in, move some android-specific code from
automation.py.in to remoteautomation.py, and eliminate some other easily-replaced
code. In the long term we want to eliminate automation.py.in completely; I may
attempt that once these changes have landed.

No longer blocks: 1621467
No longer blocks: 1621468
Keywords: leave-open
Keywords: leave-open

Remove the remainder of automation.py.in and the build support for generating
automation.py.
Some of this functionality was in use, especially for android tests.
Some code was moved or re-implemented in remoteautomation.py or in the affected
harness(es). Some features were removed: There are some minor changes in behavior.
For instance, instead of using a different server startup timeout for debug builds,
one value is used for all builds (due to performance improvements over time,
the longer timeout is no longer needed).

Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/76d9fb8a0d3d
Remove automation.py.in entirely; r=egao,bc
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.