Closed Bug 1177691 Opened 11 years ago Closed 11 years ago

New and Popular text are not bold in a category page

Categories

(Marketplace Graveyard :: Consumer Pages, defect, P4)

Avenir
defect

Tracking

(Not tracked)

VERIFIED FIXED
2015-06-30

People

(Reporter: madalin.cotetiu, Assigned: trishul.goel)

References

Details

(Whiteboard: [good first bug][lang=css])

Attachments

(1 external file, 1 obsolete file)

Steps to reproduce: 1. Open a category page on your FFOS device (i.e: News) 2. Compare the New and Popular text with the one in the mocks: https://www.dropbox.com/s/cxclx4tdj2gxg46/MOW_Preload_v2.3.pdf?dl=0 (Page 6) Expected results: The New and Popular text is bold. Actual results: The New and Popular text is not bold. Notes/Issues: Verified in FFOS 2.1 (Flame) using the dev app Screencast for this issue: http://screencast.com/t/3q90pgf4lZ
Whiteboard: [good first bug][lang=css]
Severity: normal → trivial
Priority: -- → P4
Hey, I want to work on this bug, May I?
Attached file Pull Request (obsolete) —
PR : https://github.com/mozilla/fireplace/pull/1339 Kindly check my PR, if something more needs to be done, i will be glad to fix it.
Hi Trishul, You need sent each pull request for each bug. Please remove the another commit you made for another bug. That was maybe your last commit. So you can reset your last commit :) If you need any help, please ask !
Attached file Pull Request —
As requested, PR with only one change.
Attachment #8626954 - Attachment is obsolete: true
Kindly review PR.
Flags: needinfo?(softfilebd)
font-weight: bold gives us a font-weight of 600 here, which is very heavy. yesterday, talked with Philip,as philip said we should change the font-weight to 400. And I think if you just remove the font-weight:300 from there. It gets 400 by default.
Assignee: nobody → trishul.goel
Flags: needinfo?(softfilebd)
Flags: needinfo?(softfilebd)
For me Feedback+ Please squash the commits into one . You can use the follow commands `git rebase -i HEAD~2` pick the 1st one & squash the 2nd one then `git push -f` It will be rebased into one commit
Flags: needinfo?(softfilebd)
Squashed, and many thanks, actually I learned something new.
Thanks for the patch, Trishul
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Verified as fixed in mp-dev in FFOS 2.1(Flame) Postfix screencast: http://screencast.com/t/txrk0Z4nnTb Closing bug.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: