1177916 - URLSearchParams::GetParentObject should not return nullptr

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrea Marchesini [:baku]]

Attachment: usp.patch

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8626757 [details] [diff] [review]
usp.patch

Why we need the QI to nsPIDOMWindow? Why can't we just pass aGlobal.GetAsSupports()?

Comment 2

[Andrea Marchesini [:baku]]

Attachment: usp.patch

Comment 3

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d4c34d7fb112

Comment 4

[Cameron McCormack (:heycam)]

This had to be backed out for test failures:

 1206 INFO TEST-UNEXPECTED-FAIL | dom/base/test/test_urlSearchParams.html | uncaught exception - Error: Permission denied for <http://mochi.test:8888> to create wrapper for object of class UnnamedClass at http://mochi.test:8888/tests/dom/base/test/test_urlSearchParams.html:118

Comment 5

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9280a393a6f7

Comment 6

[Cameron McCormack (:heycam)]

Also caused:

Assertion failure: NS_IsMainThread(), at /builds/slave/m-in-l64-d-0000000000000000000/build/src/dom/bindings/BindingUtils.cpp:831
TEST-UNEXPECTED-FAIL | dom/workers/test/serviceworkers/test_app_protocol.html | application terminated with exit code 11
PROCESS-CRASH | dom/workers/test/serviceworkers/test_app_protocol.html | application crashed [@ mozilla::dom::NativeInterface2JSObjectAndThrowIfFailed(JSContext*, JS::Handle<JSObject*>, JS::MutableHandle<JS::Value>, xpcObjectHelper&, nsID const*, bool)] 

(which I initially misattributed to bug 1173467)

Comment 7

[Andrea Marchesini [:baku]]

Attachment: patch 2

URL must be nsWrapperCache too.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8626916 [details] [diff] [review]
patch 2

URL needs to traverse/unlink mParent.

Comment 9

[Andrea Marchesini [:baku]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/83b50110d896
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/3462431f770d

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/83b50110d896
https://hg.mozilla.org/mozilla-central/rev/3462431f770d