Closed Bug 1177916 Opened 5 years ago Closed 5 years ago

URLSearchParams::GetParentObject should not return nullptr

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: baku, Assigned: baku)

References

Details

Attachments

(2 files, 1 obsolete file)

Attached patch usp.patch (obsolete) — Splinter Review
No description provided.
Attachment #8626757 - Flags: review?(bugs)
Comment on attachment 8626757 [details] [diff] [review]
usp.patch

Why we need the QI to nsPIDOMWindow? Why can't we just pass aGlobal.GetAsSupports()?
Attachment #8626757 - Flags: review?(bugs) → review-
Attached patch usp.patchSplinter Review
Attachment #8626757 - Attachment is obsolete: true
Attachment #8626841 - Flags: review?(bugs)
Attachment #8626841 - Flags: review?(bugs) → review+
This had to be backed out for test failures:

 1206 INFO TEST-UNEXPECTED-FAIL | dom/base/test/test_urlSearchParams.html | uncaught exception - Error: Permission denied for <http://mochi.test:8888> to create wrapper for object of class UnnamedClass at http://mochi.test:8888/tests/dom/base/test/test_urlSearchParams.html:118
Also caused:

Assertion failure: NS_IsMainThread(), at /builds/slave/m-in-l64-d-0000000000000000000/build/src/dom/bindings/BindingUtils.cpp:831
TEST-UNEXPECTED-FAIL | dom/workers/test/serviceworkers/test_app_protocol.html | application terminated with exit code 11
PROCESS-CRASH | dom/workers/test/serviceworkers/test_app_protocol.html | application crashed [@ mozilla::dom::NativeInterface2JSObjectAndThrowIfFailed(JSContext*, JS::Handle<JSObject*>, JS::MutableHandle<JS::Value>, xpcObjectHelper&, nsID const*, bool)] 

(which I initially misattributed to bug 1173467)
Attached patch patch 2Splinter Review
URL must be nsWrapperCache too.
Attachment #8626916 - Flags: review?(bugs)
Comment on attachment 8626916 [details] [diff] [review]
patch 2

URL needs to traverse/unlink mParent.
Attachment #8626916 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/83b50110d896
https://hg.mozilla.org/mozilla-central/rev/3462431f770d
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Depends on: 1183450
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.