Closed Bug 1177921 Opened 4 years ago Closed 4 years ago

ice_unittest has numerous failures when not running in CI

Categories

(Core :: WebRTC: Networking, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed
Blocking Flags:

People

(Reporter: bwc, Assigned: bwc)

Details

Attachments

(2 files)

The tests that require an external STUN server (and are therefore disabled in CI) are extremely unreliable now. It seems that either twilio's STUN servers are broken, or there is some interop problem.
0. Can you post an error report here?
1. What happens if you use Googles's STUN servers?
Google's STUN server and our STUN server behave similarly, but still lead to failures since they do not support TCP. Using twilio's STUN server leads to lots of timeouts when trying to gather. I'm going to try increasing the timeout.
Extending timeouts doesn't work. Also, I'm seeing lots of failures in tests that do non-default things like disabling ICE TCP, or enabling loopback, because we now init an NrIceCtx (with the default settings) to back the test STUN TCP server. This inits the registry with the defaults, so subsequent setting don't stick anymore. I have no idea how these tests are passing on CI...
Oh wow, MOZ_WEBRTC_TESTS=1 is no longer set in CI, so the test doesn't run at all...
Huh, we are running this test on OS X, and it works there. This is a real mess.
Assignee: nobody → docfaraday
Rank: 15
Priority: -- → P1
backlog: --- → webRTC+
Given the other work on our plates (and until I hire more folks), I think we need to move this down to a P2.  I'll do the same for bug 1178349.
Rank: 15 → 23
Priority: P1 → P2
Bug 1177921 - Fix typo in STUN server name. r?drno
Attachment #8642031 - Flags: review?(drno)
(In reply to Byron Campen [:bwc] from comment #2)
> Google's STUN server and our STUN server behave similarly, but still lead to
> failures since they do not support TCP. Using twilio's STUN server leads to
> lots of timeouts when trying to gather. I'm going to try increasing the
> timeout.

At least part of the problem here is the typo I just fixed. The tests seem to run cleanly on my local machine now.
With the above patch, I just successfully ran the tests 10x on my Linux box.
Comment on attachment 8642031 [details]
MozReview Request: Bug 1177921 - Fix typo in STUN server name. r?drno

https://reviewboard.mozilla.org/r/14675/#review13291

Ship It!
Attachment #8642031 - Flags: review+
Whiteboard: checkin-needed
Attachment #8642031 - Flags: review?(drno)
Whiteboard: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/03f8c335d0e0
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.