ice_unittest is not running in CI on linux

RESOLVED FIXED in Firefox 42

Status

()

defect
P2
normal
Rank:
23
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: bwc, Assigned: bwc)

Tracking

Trunk
mozilla42
Points:
---

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment)

We don't seem to be setting MOZ_WEBRTC_TESTS=1 on linux anymore, so ice_unittest isn't actually testing anything in CI on linux.
Assignee: nobody → docfaraday
backlog: --- → webRTC+
Rank: 15
Priority: -- → P1
Given the other work on our plates (and until I hire more folks), I think we need to move this down to a P2.  I've the same for bug 1177921.
Rank: 15 → 23
Priority: P1 → P2
Bug 1178349 - Re-enable ice_unittest on Linux. r?drno
Attachment #8642037 - Flags: review?(drno)
Looks like we can probably re-enable this, pending repeated try runs at:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=99ebeed6c896
Comment on attachment 8642037 [details]
MozReview Request: Bug 1178349 - Enable ice_unittests on desktop linux on CI

OK, that was a result of not enough coffee.
Attachment #8642037 - Flags: review?(drno)
Attachment #8642037 - Attachment is obsolete: true
Comment on attachment 8642037 [details]
MozReview Request: Bug 1178349 - Enable ice_unittests on desktop linux on CI

Bug 1178349 - Re-enable ice_unittest on Linux. r?drno
Attachment #8642037 - Attachment is obsolete: false
Attachment #8642037 - Flags: review?(drno)
Come back later when try push is done.
Flags: needinfo?(ekr)
OK this now looks good.
Flags: needinfo?(ekr)
Comment on attachment 8642037 [details]
MozReview Request: Bug 1178349 - Enable ice_unittests on desktop linux on CI

https://reviewboard.mozilla.org/r/14683/#review13293

Ship It!

::: media/mtransport/test/ice_unittest.cpp
(Diff revision 2)
> -#ifdef LINUX
> -  // This test can cause intermittent oranges on the builders on Linux
> -  CHECK_ENVIRONMENT_FLAG("MOZ_WEBRTC_TESTS")
> -#endif
> -

I approve!
Attachment #8642037 - Flags: review+
Keywords: checkin-needed
Attachment #8642037 - Flags: review?(drno)
I'm not seeing the segmentation fault. I do see a test failure.

In any case, I'm not sure what's going on on Android, but it seems like
the right fix here is to just disable execution there but leave it on
for the rest of Linux until we figure it out. Is there a convenient
#ifdef for that?
(In reply to Eric Rescorla (:ekr) from comment #12)
> it seems like
> the right fix here is to just disable execution there but leave it on
> for the rest of Linux until we figure it out. Is there a convenient
> #ifdef for that?

I think you want "#ifdef ANDROID" -- see https://wiki.mozilla.org/Platform/Platform-specific_build_defines
Comment on attachment 8642037 [details]
MozReview Request: Bug 1178349 - Enable ice_unittests on desktop linux on CI

Bug 1178349 - Enable ice_unittests on desktop linux on CI
Attachment #8642037 - Attachment description: MozReview Request: Bug 1178349 - Re-enable ice_unittest on Linux. r?drno → MozReview Request: Bug 1178349 - Enable ice_unittests on desktop linux on CI
Attachment #8642037 - Flags: review?(drno)
Byron, this is looking good. Can I get your r+?

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9819df9af2db
I think you already have it.
I revised the patch, so I need a new review.
Oh, I guess reviewboard doesn't clear the r+ anymore.
Keywords: checkin-needed
And now not only pulsebot blames me for the review, but mozreview as well.... well at least now I know how to get required reviews from people which are overloaded.
Attachment #8642037 - Flags: review?(drno) → review+
https://hg.mozilla.org/mozilla-central/rev/29cc14174cc7
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.