1178349 - ice_unittest is not running in CI on linux

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P2)

Description

[Byron Campen [:bwc]]

We don't seem to be setting MOZ_WEBRTC_TESTS=1 on linux anymore, so ice_unittest isn't actually testing anything in CI on linux.

Comment 1

[Maire Reavy [:mreavy]]

Given the other work on our plates (and until I hire more folks), I think we need to move this down to a P2.  I've the same for bug 1177921.

Comment 2

[Eric Rescorla (:ekr)]

Attachment: MozReview Request: Bug 1178349 - Enable ice_unittests on desktop linux on CI

Bug 1178349 - Re-enable ice_unittest on Linux. r?drno

Comment 3

[Eric Rescorla (:ekr)]

Looks like we can probably re-enable this, pending repeated try runs at:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=99ebeed6c896

Comment 4

[Eric Rescorla (:ekr)]

Comment on attachment 8642037 [details]
MozReview Request: Bug 1178349 - Enable ice_unittests on desktop linux on CI

OK, that was a result of not enough coffee.

Comment 5

[Eric Rescorla (:ekr)]

Comment on attachment 8642037 [details]
MozReview Request: Bug 1178349 - Enable ice_unittests on desktop linux on CI

Bug 1178349 - Re-enable ice_unittest on Linux. r?drno

Comment 6

[Eric Rescorla (:ekr)]

Now with a new try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=402b9b2e33b1

Comment 7

[Eric Rescorla (:ekr)]

Come back later when try push is done.

Comment 8

[Eric Rescorla (:ekr)]

OK this now looks good.

Comment 9

[Byron Campen [:bwc]]

Comment on attachment 8642037 [details]
MozReview Request: Bug 1178349 - Enable ice_unittests on desktop linux on CI

https://reviewboard.mozilla.org/r/14683/#review13293

Ship It!

::: media/mtransport/test/ice_unittest.cpp
(Diff revision 2)
> -#ifdef LINUX
> -  // This test can cause intermittent oranges on the builders on Linux
> -  CHECK_ENVIRONMENT_FLAG("MOZ_WEBRTC_TESTS")
> -#endif
> -

I approve!

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/62561970f611

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Backed out for Android segfaults.
https://treeherder.mozilla.org/logviewer.html#?job_id=12436015&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/579d50cc0ca7

Comment 12

[Eric Rescorla (:ekr)]

I'm not seeing the segmentation fault. I do see a test failure.

In any case, I'm not sure what's going on on Android, but it seems like
the right fix here is to just disable execution there but leave it on
for the rest of Linux until we figure it out. Is there a convenient
#ifdef for that?

Comment 13

[Nils Ohlmeier [:drno]]

I think Ryan meant to link to this seg fault: https://treeherder.mozilla.org/logviewer.html#?job_id=12434002&repo=mozilla-inbound

Comment 14

[Adam Roach [:abr]]

(In reply to Eric Rescorla (:ekr) from comment #12)
> it seems like
> the right fix here is to just disable execution there but leave it on
> for the rest of Linux until we figure it out. Is there a convenient
> #ifdef for that?

I think you want "#ifdef ANDROID" -- see https://wiki.mozilla.org/Platform/Platform-specific_build_defines

Comment 15

[Eric Rescorla (:ekr)]

Comment on attachment 8642037 [details]
MozReview Request: Bug 1178349 - Enable ice_unittests on desktop linux on CI

Bug 1178349 - Enable ice_unittests on desktop linux on CI

Comment 16

[Eric Rescorla (:ekr)]

Byron, this is looking good. Can I get your r+?

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9819df9af2db

Comment 17

[Byron Campen [:bwc]]

I think you already have it.

Comment 18

[Eric Rescorla (:ekr)]

I revised the patch, so I need a new review.

Comment 19

[Byron Campen [:bwc]]

Oh, I guess reviewboard doesn't clear the r+ anymore.

Comment 20

[Byron Campen [:bwc]]

https://reviewboard.mozilla.org/r/14683/#review13467

Ship It!

Comment 21

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/29cc14174cc7

Comment 22

[Nils Ohlmeier [:drno]]

And now not only pulsebot blames me for the review, but mozreview as well.... well at least now I know how to get required reviews from people which are overloaded.

Comment 23

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/29cc14174cc7