1178186 - Add CSSAnimation and CSSTransition interfaces

Status: RESOLVED FIXED

(Core :: DOM: Animation, defect)

Description

[Brian Birtles (:birtles)]

This will let us distinguish between CSS animations and transitions. Draft spec text:

* https://rawgit.com/shans/csswg-drafts/animations-2/css-animations-2/Overview.html#the-CSSAnimation-interface
* https://rawgit.com/shans/csswg-drafts/animations-2/css-transitions-2/Overview.html#the-CSSTransition-interface

Comment 1

[Brian Birtles (:birtles)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b8beae2d6706

Comment 2

[Brian Birtles (:birtles)]

Attachment: MozReview Request: Bug 1178186 part 1 - Add CSSAnimation and CSSTransition interfaces

Bug 1178186 part 1 - Add CSSAnimation and CSSTransition interfaces

Comment 3

[Brian Birtles (:birtles)]

Attachment: MozReview Request: Bug 1178186 part 2 - Add tests for CSSAnimation and CSSTransition interfaces

Bug 1178186 part 2 - Add tests for CSSAnimation and CSSTransition interfaces

Comment 4

[Brian Birtles (:birtles)]

https://reviewboard.mozilla.org/r/12249/#review10723

::: dom/webidl/CSSAnimation.webidl:7
(Diff revision 1)
> + * http://dev.w3.org/csswg/css-animations-2/#the-CSSAnimation-interface

Note that this URL doesn't exist yet, but should do once we merge this branch in:
https://rawgit.com/shans/csswg-drafts/animations-2/css-animations-2/Overview.html#the-CSSAnimation-interface

Similarly for the CSSTransition.webidl file.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8627478 [details]
MozReview Request: Bug 1178186 part 1 - Add CSSAnimation and CSSTransition interfaces

Rather odd to add just the interfaces, but not any properties.
But I assume this won't be ever in a release build this way.

Comment 6

[Brian Birtles (:birtles)]

(In reply to Olli Pettay [:smaug] from comment #5)
> Comment on attachment 8627478 [details]
> MozReview Request: Bug 1178186 part 1 - Add CSSAnimation and CSSTransition
> interfaces
> 
> Rather odd to add just the interfaces, but not any properties.
> But I assume this won't be ever in a release build this way.

Yes. I'll add some properties in a follow up bug soon.

Comment 7

[Jonathan Watt [:jwatt]]

Comment on attachment 8627479 [details]
MozReview Request: Bug 1178186 part 2 - Add tests for CSSAnimation and CSSTransition interfaces

https://reviewboard.mozilla.org/r/12251/#review11167

Ship It!

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1e1ccffd51b8
https://hg.mozilla.org/integration/mozilla-inbound/rev/1027311cd1bb

Comment 9

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8b9502a90991
https://hg.mozilla.org/integration/mozilla-inbound/rev/b7dd09838e2c

Comment 10

[Carsten Book [:Tomcat]]

sorry had to back this out in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=b7dd09838e2c since i think one of this changes caused https://treeherder.mozilla.org/logviewer.html#?job_id=11428266&repo=mozilla-inbound

Comment 11

[Ryan VanderMeulen [:RyanVM]]

This wasn't at fault. Will re-land.

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d78aadae7055
https://hg.mozilla.org/integration/mozilla-inbound/rev/2cd25af5d089

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d78aadae7055
https://hg.mozilla.org/mozilla-central/rev/2cd25af5d089