Closed
Bug 1179111
Opened 9 years ago
Closed 9 years ago
Implement CSSAnimation.animationName and CSSTransition.transitionProperty
Categories
(Core :: DOM: Animation, defect)
Core
DOM: Animation
Tracking
()
RESOLVED
FIXED
mozilla42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: birtles, Assigned: birtles)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-needed)
Attachments
(5 files)
|
40 bytes,
text/x-review-board-request
|
smaug
:
review+
jwatt
:
review+
|
Details |
|
40 bytes,
text/x-review-board-request
|
smaug
:
review+
jwatt
:
review+
|
Details |
|
40 bytes,
text/x-review-board-request
|
pbro
:
review+
|
Details |
|
40 bytes,
text/x-review-board-request
|
smaug
:
review+
|
Details |
|
40 bytes,
text/x-review-board-request
|
jwatt
:
review+
|
Details |
https://rawgit.com/shans/csswg-drafts/animations-2/css-animations-2/Overview.html#dom-cssanimation-animationname https://rawgit.com/shans/csswg-drafts/animations-2/css-transitions-2/Overview.html#dom-csstransition-transitionproperty
|
Assignee | |
Comment 1•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=717ea94f0b1b
|
|
Assignee | |
Comment 2•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=027d622cbeba
|
|
Assignee | |
Comment 3•9 years ago
|
||
Bug 1179111 part 1 - Implement CSSAnimation.animationName
Attachment #8628581 -
Flags: review?(jwatt)
Attachment #8628581 -
Flags: review?(bugs)
|
|
Assignee | |
Comment 4•9 years ago
|
||
Bug 1179111 part 2 - Implement CSSTransition.transitionProperty
Attachment #8628582 -
Flags: review?(jwatt)
Attachment #8628582 -
Flags: review?(bugs)
|
|
Assignee | |
Comment 5•9 years ago
|
||
Bug 1179111 part 3 - Make DevTools read the appropriate name property
Attachment #8628583 -
Flags: review?(pbrosset)
|
|
Assignee | |
Comment 6•9 years ago
|
||
Bug 1179111 part 4 - Remove KeyframeEffectReadOnly.name
Attachment #8628584 -
Flags: review?(bugs)
|
|
Assignee | |
Comment 7•9 years ago
|
||
Bug 1179111 part 5 - Remove Name() methods
Attachment #8628585 -
Flags: review?(jwatt)
|
|
Assignee | |
Comment 8•9 years ago
|
||
Oops, looks like there's a bug in part 3... here's hoping MozReview doesn't punish me for trying to update the patch.
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8628583 -
Flags: review?(pbrosset)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8628583 -
Flags: review?(pbrosset)
|
|
Assignee | |
Comment 9•9 years ago
|
||
Comment on attachment 8628583 [details] MozReview Request: Bug 1179111 part 3 - Make DevTools read the appropriate name property Bug 1179111 part 3 - Make DevTools read the appropriate name property
|
|
Assignee | |
Comment 10•9 years ago
|
||
Comment on attachment 8628584 [details] MozReview Request: Bug 1179111 part 4 - Remove KeyframeEffectReadOnly.name Bug 1179111 part 4 - Remove KeyframeEffectReadOnly.name
|
|
Assignee | |
Comment 11•9 years ago
|
||
Comment on attachment 8628585 [details] MozReview Request: Bug 1179111 part 5 - Remove Name() methods Bug 1179111 part 5 - Remove Name() methods
|
|
Assignee | |
Comment 12•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c2656cfb8785
|
||
Comment 13•9 years ago
|
||
Comment on attachment 8628581 [details] MozReview Request: Bug 1179111 part 1 - Implement CSSAnimation.animationName So animationName never ever changes, right?
Attachment #8628581 -
Flags: review?(bugs) → review+
|
|
||
Comment 14•9 years ago
|
||
Comment on attachment 8628582 [details] MozReview Request: Bug 1179111 part 2 - Implement CSSTransition.transitionProperty ditto
Attachment #8628582 -
Flags: review?(bugs) → review+
|
|
||
Updated•9 years ago
|
Attachment #8628584 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 15•9 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #13) > Comment on attachment 8628581 [details] > MozReview Request: Bug 1179111 part 1 - Implement CSSAnimation.animationName > > So animationName never ever changes, right? Right. It is set when the object is constructed and then never changes.
|
||
Comment 16•9 years ago
|
||
Comment on attachment 8628583 [details] MozReview Request: Bug 1179111 part 3 - Make DevTools read the appropriate name property https://reviewboard.mozilla.org/r/12459/#review11053 Ship It! ::: toolkit/devtools/server/actors/animation.js:649 (Diff revision 2) > + a.player.animationName === player.animationName) || Can you add 2 methods on the class: isAnimation: function(player=this.player) { return player.instanceof this.tabActor.window.CSSAnimation; }, isTransition: function(player=this.player) { return player.instanceof this.tabActor.window.CSSTransition; } And use them here to make the condition simpler, as well as above in getName.
Attachment #8628583 -
Flags: review?(pbrosset) → review+
|
||
Comment 17•9 years ago
|
||
Comment on attachment 8628581 [details] MozReview Request: Bug 1179111 part 1 - Implement CSSAnimation.animationName https://reviewboard.mozilla.org/r/12455/#review11155 Ship It!
Attachment #8628581 -
Flags: review?(jwatt) → review+
|
|
||
Comment 18•9 years ago
|
||
Comment on attachment 8628582 [details] MozReview Request: Bug 1179111 part 2 - Implement CSSTransition.transitionProperty https://reviewboard.mozilla.org/r/12457/#review11157 Ship It!
Attachment #8628582 -
Flags: review?(jwatt) → review+
|
|
||
Comment 19•9 years ago
|
||
Comment on attachment 8628585 [details] MozReview Request: Bug 1179111 part 5 - Remove Name() methods https://reviewboard.mozilla.org/r/12463/#review11161 Ship It! ::: layout/style/nsAnimationManager.h:62 (Diff revision 2) > + , mAnimationName(aAnimationName) Maybe assert in the ctor that aAnimationName is not Empty().
Attachment #8628585 -
Flags: review?(jwatt) → review+
|
||
Comment 20•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/144276fd40a1 https://hg.mozilla.org/integration/mozilla-inbound/rev/4eb184faf92c https://hg.mozilla.org/integration/mozilla-inbound/rev/17bcfd0ff1df https://hg.mozilla.org/integration/mozilla-inbound/rev/171d0e4ec35d https://hg.mozilla.org/integration/mozilla-inbound/rev/22cafa2fd162
|
|
Assignee | |
Comment 21•9 years ago
|
||
Try run of the same: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bd1c6821cd75
|
|
||
Comment 22•9 years ago
|
||
Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/078b3200cdd4 https://hg.mozilla.org/integration/mozilla-inbound/rev/a46c51f88f7c https://hg.mozilla.org/integration/mozilla-inbound/rev/ceeae7a0a4f5 https://hg.mozilla.org/integration/mozilla-inbound/rev/0f256f2b3cf4 https://hg.mozilla.org/integration/mozilla-inbound/rev/252d5e965cd4
|
||
Comment 23•9 years ago
|
||
sorry had to back this out in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=b7dd09838e2c since i think one of this changes caused https://treeherder.mozilla.org/logviewer.html#?job_id=11428266&repo=mozilla-inbound
|
||
Comment 24•9 years ago
|
||
This wasn't at fault. Will re-land.
|
|
||
Comment 25•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f3d6732fe800 https://hg.mozilla.org/integration/mozilla-inbound/rev/da019eaeffd5 https://hg.mozilla.org/integration/mozilla-inbound/rev/9a49f1eefad8 https://hg.mozilla.org/integration/mozilla-inbound/rev/d31659aa4627 https://hg.mozilla.org/integration/mozilla-inbound/rev/e965cd35db97
https://hg.mozilla.org/mozilla-central/rev/f3d6732fe800 https://hg.mozilla.org/mozilla-central/rev/da019eaeffd5 https://hg.mozilla.org/mozilla-central/rev/9a49f1eefad8 https://hg.mozilla.org/mozilla-central/rev/d31659aa4627 https://hg.mozilla.org/mozilla-central/rev/e965cd35db97
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
|
||
Updated•9 years ago
|
Keywords: dev-doc-needed
You need to log in
before you can comment on or make changes to this bug.
Description
•