1179111 - Implement CSSAnimation.animationName and CSSTransition.transitionProperty

Status: RESOLVED FIXED

(Core :: DOM: Animation, defect)

Description

[Brian Birtles (:birtles)]

https://rawgit.com/shans/csswg-drafts/animations-2/css-animations-2/Overview.html#dom-cssanimation-animationname
https://rawgit.com/shans/csswg-drafts/animations-2/css-transitions-2/Overview.html#dom-csstransition-transitionproperty

Comment 1

[Brian Birtles (:birtles)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=717ea94f0b1b

Comment 2

[Brian Birtles (:birtles)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=027d622cbeba

Comment 3

[Brian Birtles (:birtles)]

Attachment: MozReview Request: Bug 1179111 part 1 - Implement CSSAnimation.animationName

Bug 1179111 part 1 - Implement CSSAnimation.animationName

Comment 4

[Brian Birtles (:birtles)]

Attachment: MozReview Request: Bug 1179111 part 2 - Implement CSSTransition.transitionProperty

Bug 1179111 part 2 - Implement CSSTransition.transitionProperty

Comment 5

[Brian Birtles (:birtles)]

Attachment: MozReview Request: Bug 1179111 part 3 - Make DevTools read the appropriate name property

Bug 1179111 part 3 - Make DevTools read the appropriate name property

Comment 6

[Brian Birtles (:birtles)]

Attachment: MozReview Request: Bug 1179111 part 4 - Remove KeyframeEffectReadOnly.name

Bug 1179111 part 4 - Remove KeyframeEffectReadOnly.name

Comment 7

[Brian Birtles (:birtles)]

Attachment: MozReview Request: Bug 1179111 part 5 - Remove Name() methods

Bug 1179111 part 5 - Remove Name() methods

Comment 8

[Brian Birtles (:birtles)]

Oops, looks like there's a bug in part 3... here's hoping MozReview doesn't punish me for trying to update the patch.

Comment 9

[Brian Birtles (:birtles)]

Comment on attachment 8628583 [details]
MozReview Request: Bug 1179111 part 3 - Make DevTools read the appropriate name property

Bug 1179111 part 3 - Make DevTools read the appropriate name property

Comment 10

[Brian Birtles (:birtles)]

Comment on attachment 8628584 [details]
MozReview Request: Bug 1179111 part 4 - Remove KeyframeEffectReadOnly.name

Bug 1179111 part 4 - Remove KeyframeEffectReadOnly.name

Comment 11

[Brian Birtles (:birtles)]

Comment on attachment 8628585 [details]
MozReview Request: Bug 1179111 part 5 - Remove Name() methods

Bug 1179111 part 5 - Remove Name() methods

Comment 12

[Brian Birtles (:birtles)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c2656cfb8785

Comment 13

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8628581 [details]
MozReview Request: Bug 1179111 part 1 - Implement CSSAnimation.animationName

So animationName never ever changes, right?

Comment 14

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8628582 [details]
MozReview Request: Bug 1179111 part 2 - Implement CSSTransition.transitionProperty

ditto

Comment 15

[Brian Birtles (:birtles)]

(In reply to Olli Pettay [:smaug] from comment #13)
> Comment on attachment 8628581 [details]
> MozReview Request: Bug 1179111 part 1 - Implement CSSAnimation.animationName
> 
> So animationName never ever changes, right?

Right. It is set when the object is constructed and then never changes.

Comment 16

[Patrick Brosset <:pbro>]

Comment on attachment 8628583 [details]
MozReview Request: Bug 1179111 part 3 - Make DevTools read the appropriate name property

https://reviewboard.mozilla.org/r/12459/#review11053

Ship It!

::: toolkit/devtools/server/actors/animation.js:649
(Diff revision 2)
> +                   a.player.animationName === player.animationName) ||

Can you add 2 methods on the class:

isAnimation: function(player=this.player) {
  return player.instanceof this.tabActor.window.CSSAnimation;
},

isTransition: function(player=this.player) {
  return player.instanceof this.tabActor.window.CSSTransition;
}

And use them here to make the condition simpler, as well as above in getName.

Comment 17

[Jonathan Watt [:jwatt]]

Comment on attachment 8628581 [details]
MozReview Request: Bug 1179111 part 1 - Implement CSSAnimation.animationName

https://reviewboard.mozilla.org/r/12455/#review11155

Ship It!

Comment 18

[Jonathan Watt [:jwatt]]

Comment on attachment 8628582 [details]
MozReview Request: Bug 1179111 part 2 - Implement CSSTransition.transitionProperty

https://reviewboard.mozilla.org/r/12457/#review11157

Ship It!

Comment 19

[Jonathan Watt [:jwatt]]

Comment on attachment 8628585 [details]
MozReview Request: Bug 1179111 part 5 - Remove Name() methods

https://reviewboard.mozilla.org/r/12463/#review11161

Ship It!

::: layout/style/nsAnimationManager.h:62
(Diff revision 2)
> +    , mAnimationName(aAnimationName)

Maybe assert in the ctor that aAnimationName is not Empty().

Comment 20

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/144276fd40a1
https://hg.mozilla.org/integration/mozilla-inbound/rev/4eb184faf92c
https://hg.mozilla.org/integration/mozilla-inbound/rev/17bcfd0ff1df
https://hg.mozilla.org/integration/mozilla-inbound/rev/171d0e4ec35d
https://hg.mozilla.org/integration/mozilla-inbound/rev/22cafa2fd162

Comment 21

[Brian Birtles (:birtles)]

Try run of the same:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bd1c6821cd75

Comment 22

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/078b3200cdd4
https://hg.mozilla.org/integration/mozilla-inbound/rev/a46c51f88f7c
https://hg.mozilla.org/integration/mozilla-inbound/rev/ceeae7a0a4f5
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f256f2b3cf4
https://hg.mozilla.org/integration/mozilla-inbound/rev/252d5e965cd4

Comment 23

[Carsten Book [:Tomcat]]

sorry had to back this out in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=b7dd09838e2c since i think one of this changes caused https://treeherder.mozilla.org/logviewer.html#?job_id=11428266&repo=mozilla-inbound

Comment 24

[Ryan VanderMeulen [:RyanVM]]

This wasn't at fault. Will re-land.

Comment 25

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f3d6732fe800
https://hg.mozilla.org/integration/mozilla-inbound/rev/da019eaeffd5
https://hg.mozilla.org/integration/mozilla-inbound/rev/9a49f1eefad8
https://hg.mozilla.org/integration/mozilla-inbound/rev/d31659aa4627
https://hg.mozilla.org/integration/mozilla-inbound/rev/e965cd35db97

Comment 26

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f3d6732fe800
https://hg.mozilla.org/mozilla-central/rev/da019eaeffd5
https://hg.mozilla.org/mozilla-central/rev/9a49f1eefad8
https://hg.mozilla.org/mozilla-central/rev/d31659aa4627
https://hg.mozilla.org/mozilla-central/rev/e965cd35db97