Closed Bug 1179111 Opened 4 years ago Closed 4 years ago

Implement CSSAnimation.animationName and CSSTransition.transitionProperty

Categories

(Core :: DOM: Animation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: birtles, Assigned: birtles)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-needed)

Attachments

(5 files)

Bug 1179111 part 1 - Implement CSSAnimation.animationName
Attachment #8628581 - Flags: review?(jwatt)
Attachment #8628581 - Flags: review?(bugs)
Bug 1179111 part 2 - Implement CSSTransition.transitionProperty
Attachment #8628582 - Flags: review?(jwatt)
Attachment #8628582 - Flags: review?(bugs)
Bug 1179111 part 3 - Make DevTools read the appropriate name property
Attachment #8628583 - Flags: review?(pbrosset)
Bug 1179111 part 4 - Remove KeyframeEffectReadOnly.name
Attachment #8628584 - Flags: review?(bugs)
Bug 1179111 part 5 - Remove Name() methods
Attachment #8628585 - Flags: review?(jwatt)
Oops, looks like there's a bug in part 3... here's hoping MozReview doesn't punish me for trying to update the patch.
Attachment #8628583 - Flags: review?(pbrosset)
Attachment #8628583 - Flags: review?(pbrosset)
Comment on attachment 8628583 [details]
MozReview Request: Bug 1179111 part 3 - Make DevTools read the appropriate name property

Bug 1179111 part 3 - Make DevTools read the appropriate name property
Comment on attachment 8628584 [details]
MozReview Request: Bug 1179111 part 4 - Remove KeyframeEffectReadOnly.name

Bug 1179111 part 4 - Remove KeyframeEffectReadOnly.name
Comment on attachment 8628585 [details]
MozReview Request: Bug 1179111 part 5 - Remove Name() methods

Bug 1179111 part 5 - Remove Name() methods
Comment on attachment 8628581 [details]
MozReview Request: Bug 1179111 part 1 - Implement CSSAnimation.animationName

So animationName never ever changes, right?
Attachment #8628581 - Flags: review?(bugs) → review+
Comment on attachment 8628582 [details]
MozReview Request: Bug 1179111 part 2 - Implement CSSTransition.transitionProperty

ditto
Attachment #8628582 - Flags: review?(bugs) → review+
Attachment #8628584 - Flags: review?(bugs) → review+
(In reply to Olli Pettay [:smaug] from comment #13)
> Comment on attachment 8628581 [details]
> MozReview Request: Bug 1179111 part 1 - Implement CSSAnimation.animationName
> 
> So animationName never ever changes, right?

Right. It is set when the object is constructed and then never changes.
Comment on attachment 8628583 [details]
MozReview Request: Bug 1179111 part 3 - Make DevTools read the appropriate name property

https://reviewboard.mozilla.org/r/12459/#review11053

Ship It!

::: toolkit/devtools/server/actors/animation.js:649
(Diff revision 2)
> +                   a.player.animationName === player.animationName) ||

Can you add 2 methods on the class:

isAnimation: function(player=this.player) {
  return player.instanceof this.tabActor.window.CSSAnimation;
},

isTransition: function(player=this.player) {
  return player.instanceof this.tabActor.window.CSSTransition;
}

And use them here to make the condition simpler, as well as above in getName.
Attachment #8628583 - Flags: review?(pbrosset) → review+
Comment on attachment 8628581 [details]
MozReview Request: Bug 1179111 part 1 - Implement CSSAnimation.animationName

https://reviewboard.mozilla.org/r/12455/#review11155

Ship It!
Attachment #8628581 - Flags: review?(jwatt) → review+
Comment on attachment 8628582 [details]
MozReview Request: Bug 1179111 part 2 - Implement CSSTransition.transitionProperty

https://reviewboard.mozilla.org/r/12457/#review11157

Ship It!
Attachment #8628582 - Flags: review?(jwatt) → review+
Comment on attachment 8628585 [details]
MozReview Request: Bug 1179111 part 5 - Remove Name() methods

https://reviewboard.mozilla.org/r/12463/#review11161

Ship It!

::: layout/style/nsAnimationManager.h:62
(Diff revision 2)
> +    , mAnimationName(aAnimationName)

Maybe assert in the ctor that aAnimationName is not Empty().
Attachment #8628585 - Flags: review?(jwatt) → review+
This wasn't at fault. Will re-land.
You need to log in before you can comment on or make changes to this bug.