1178241 - [vCard] 'undefined' is displayed when a field exist but there's no value in it

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Johan Lorenzo [:jlorenzo]]

Attachment: sample.vcf

STR
1. Put the attached vcard on your device
2. Import it.
3. See the contact list

Results
The displayed company is 'undefined' instead of having no company. The vCard is not common, it shows:
> ORG:;

This seems like an edge case, but in real life, this happened to me with Fastmail. They do export contacts with ORG but without filling it. And per the specs[1], it seems okay to do so.

[1] https://tools.ietf.org/html/rfc6350#section-6.6.4

Comment 1

[Johan Lorenzo [:jlorenzo]]

[Blocking Requested - why for this release]: We have likely lived with this issue for multiple releases. However, having a list of contacts filled with 'undefined' everywhere will hurt the first user experience, and as said above, this happens with at least one of the major email provider.

Comment 2

[Johan Lorenzo [:jlorenzo]]

Comms triage: Agreed to follow the specs.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] arcturus:bug-1178241 > mozilla-b2g:master

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to pr

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/commit/74b3468bf3ec58140179e971d4b989e189e7ed49

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1178241-backout > mozilla-b2g:master

Comment 7

[Alberto Pastor [:albertopq]]

GU7 is perma-failing because of this patch. Could you please take a look and reland? Thanks!

backout: https://github.com/mozilla-b2g/gaia/commit/b57e9a0b5aee45f80d1ee8bfe69625ab4db20b5c

Comment 8

[Carsten Book [:Tomcat]]

https://treeherder.mozilla.org/logviewer.html#?job_id=2467925&repo=b2g-inbound was the failure btw

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Reverted:

https://github.com/mozilla-b2g/gaia/commit/148b69dc19a9a26b854675d60808408bc4982e59

Comment 10

[GitHub Autolander Bot]

Attachment: [gaia] arcturus:bug-1178241 > mozilla-b2g:master

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8643665 [details] [review]
[gaia] arcturus:bug-1178241 > mozilla-b2g:master

Carrying over the r+ since this just fixes the tests.

Comment 12

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/commit/2a3160f6c72c04fe5dddab4bb10af46d1493a59d

Comment 13

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0.

Actual results: "undefined" is not displayed when a field exist but there's no value in it. 
See attachment: verified_Flame_v2.5.3gp
Reproduce rate: 0/10


Device: Flame KK 2.5 (Pass)
Build ID               20150810150206
Gaia Revision          9a8880a95ee4a4aea7895d4e2bcab31bc49ea281
Gaia Date              2015-08-10 16:01:11
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/8cba870a352c
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150810.183734
Firmware Date          Mon Aug 10 18:37:46 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5(Pass)
Build ID               20150810201912
Gaia Revision          fa89e03dc489e79baa0e74cb1d205260c7924caa
Gaia Date              2015-08-10 10:07:57
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/3f135a8ead22
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150810.194258
Firmware Date          Mon Aug 10 19:43:05 UTC 2015
Bootloader             s1

Comment 14

[Shally Li（leave from Mozilla）]

Attachment: verified_Flame_v2.5.3gp