1178418 - When importing a multiple contacts vcard, if a contact does not have Company field, "false" is shown in the import contacts list

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Maria Angeles Oteo (:oteo)]

Attachment: 2015-06-29-20-00-30.png

When verifying bug 1134995, this issue was already raised (see https://bugzilla.mozilla.org/show_bug.cgi?id=1134995#c29)

STR：
1.Receive a mail with an vcard with several contacts
2.Download and open the contacts '.vcf' file.

Actual result:
Import screen shows the list of the contacts included in the vcard. In case the contacts does not have "Company" field, it shows "false" underneath the contact's name

Expected Result:
In case the contacts does not have "Company" field, "false" string should not be shown.

See https://bugzilla.mozilla.org/show_bug.cgi?id=1134995#c14 to confirm the expected behaviour provided by UX

Comment 1

[Maria Angeles Oteo (:oteo)]

[Blocking Requested - why for this release]: poor UX

Comment 2

[Johan Lorenzo [:jlorenzo]]

Might be related to bug 1178241. Maria, does your vCard file contain lines like:
> ORG:;

Comment 3

[Johan Lorenzo [:jlorenzo]]

Comms triage: Regression.

Comment 4

[Maria Angeles Oteo (:oteo)]

Attachment: muchos.vcf

(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #2)
> Might be related to bug 1178241. Maria, does your vCard file contain lines
> like:
> > ORG:;

Hi Johan,
no, it does not have those lines. I am attaching the vcard so you can check it by yourself. I think that they are different bugs. 

Importing multiple contacts vcards was a new functionality included in master (it was not uplifted to 2.2) so the bug I have just reported I think it has never worked before (so it would not be a regression but a mistake in the implementation)

Comment 5

[Maria Angeles Oteo (:oteo)]

While working on merging "import" and "open" activities, as part of the work that it's being done porting Contacts application to the NGA, Manu will try to fix this bug at the same time.
Thanks Manu for helping with this!

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] mancas:bug1178418 > mozilla-b2g:master

Comment 7

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8634028 [details] [review]
[gaia] mancas:bug1178418 > mozilla-b2g:master

Hey Borja, could you review this patch when you get a chance?

Thanks =)

Comment 8

[Maria Angeles Oteo (:oteo)]

Although this bug is previous to the NGA work, adding [NG Gaia Contacts] whiteboard in order to track it in our sprint work

Comment 9

[Maria Angeles Oteo (:oteo)]

Tested with latest master build and it works as expected. Thanks for fixing this, Manu!

Environmental Variables:
flame master (2.5 version)
Build ID: 20150727092530
Gecko: a317822
Gaia: 4e3e21a
Platform version: 42.0a1

Comment 10

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0.

Actual results: When importing a multiple contacts vcard, if a contact does not have Company field, no "false" showing in the import contacts list view. 
See attachment: verified_Aries_v2.5.png
Reproduce rate: 0/10


Device: Flame KK 2.5 (Pass)
Build ID               20150929150202
Gaia Revision          f345f6a015709beeb2ca3955cab077fcaa959d3b
Gaia Date              2015-09-29 03:53:51
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/ccee6614fd9d18a31f263fbcfe9676b224d851aa
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150929.201052
Firmware Date          Tue Sep 29 20:11:01 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 (Pass)
Build ID               20150930005445
Gaia Revision          1bc0b19527777ffee494962b48db4be857b07d64
Gaia Date              2015-09-29 20:01:07
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/891ee0d0ba3ec42b6484cf0205b3c95e21c58f74
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150930.001258
Firmware Date          Wed Sep 30 00:13:06 UTC 2015
Bootloader             s1

Comment 11

[Shally Li（leave from Mozilla）]

Attachment: verified_Aires_v2.5.png