1178320 - Multiple UITests are failing intermittently

Status: RESOLVED FIXED

(Firefox for iOS :: Build & Test, defect)

Description

[James Hugman [:jhugman] [@jhugman]]

ReadingListTests
SearchSegttingsUITest
SearchTests
ViewMemoryLeakTests

It is unclear how long these have been failing for, or if they are actually being running on the CI server.

Comment 1

[Johannes Marbach]

Attachment: Pull request (ViewMemoryLeakTests)

This pull request fixes the broken ViewMemoryLeakTests. The main issue was that the browser controller is wrapped inside a navigation controller now which was not reflected in the tests.

Comment 2

[Johannes Marbach]

Attachment: Pull request (SearchTests)

This is a separate pull request for fixing the broken SearchTests. Let me know if I shall merge everything into a single pull request. I decided not to do that for now because the tests are logically separated.

Comment 3

[James Hugman [:jhugman] [@jhugman]]

Comment on attachment 8684554 [details] [review]
Pull request (SearchTests)

r+ with nits. 

Good work! Thank you!

Fix the nits, update the PR and we can merge it in :)

Comment 4

[Johannes Marbach]

Thanks. :)

I resolved the conflicts on the SearchTests PR (https://github.com/mozilla/firefox-ios/pull/1230) and left more comments on the ViewMemoryLeakTests PR (https://github.com/mozilla/firefox-ios/pull/1229).

Comment 6

[Brian Nicholson (:bnicholson)]

Thank you for the fix!

https://github.com/mozilla/firefox-ios/commit/433fd8f5bffaed60b9b7b8a85683430b8d6b878d

Comment 7

[Brian Nicholson (:bnicholson)]

https://github.com/mozilla/firefox-ios/commit/ae7f3143fd5191c272d3885c78e44834aec6f213