Closed Bug 1178320 Opened 8 years ago Closed 7 years ago

Multiple UITests are failing intermittently

Categories

(Firefox for iOS :: Build & Test, defect)

Other
iOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jhugman, Assigned: johannesmarbach)

References

Details

Attachments

(2 files)

48 bytes, text/x-github-pull-request
jhugman
: review+
Details | Review
48 bytes, text/x-github-pull-request
jhugman
: review+
Details | Review
ReadingListTests
SearchSegttingsUITest
SearchTests
ViewMemoryLeakTests

It is unclear how long these have been failing for, or if they are actually being running on the CI server.
This pull request fixes the broken ViewMemoryLeakTests. The main issue was that the browser controller is wrapped inside a navigation controller now which was not reflected in the tests.
Attachment #8684334 - Flags: review?(jhugman)
This is a separate pull request for fixing the broken SearchTests. Let me know if I shall merge everything into a single pull request. I decided not to do that for now because the tests are logically separated.
Attachment #8684554 - Flags: review?(jhugman)
Attachment #8684334 - Attachment description: Pull request → Pull request (ViewMemoryLeakTests)
Attachment #8684554 - Attachment description: Pull request → Pull request (SearchTests)
Comment on attachment 8684554 [details] [review]
Pull request (SearchTests)

r+ with nits. 

Good work! Thank you!

Fix the nits, update the PR and we can merge it in :)
Attachment #8684554 - Flags: review?(jhugman) → review+
Attachment #8684334 - Flags: review?(jhugman) → review+
Thanks. :)

I resolved the conflicts on the SearchTests PR (https://github.com/mozilla/firefox-ios/pull/1230) and left more comments on the ViewMemoryLeakTests PR (https://github.com/mozilla/firefox-ios/pull/1229).
Thank you for the fix!

https://github.com/mozilla/firefox-ios/commit/433fd8f5bffaed60b9b7b8a85683430b8d6b878d
Assignee: nobody → johannesmarbach
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.