1178389 - Remove the parse_timestamp field from the job_log_url table

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Data Ingestion, defect, P3)

Description

[Ed Morley [:emorley]]

I think we could possibly remove the parse_timestamp field from job_log_url:

  `id` bigint(20) unsigned NOT NULL AUTO_INCREMENT,
  `job_id` bigint(20) unsigned NOT NULL,
  `name` varchar(50) COLLATE utf8_bin NOT NULL,
  `url` varchar(255) COLLATE utf8_bin NOT NULL,
  `parse_status` enum('pending', 'parsed', 'failed') COLLATE utf8_bin DEFAULT 'pending',
  `parse_timestamp` int(10) NOT NULL,
  `active_status` enum('active','onhold','deleted') COLLATE utf8_bin DEFAULT 'active',

Since iirc we don't actually use it anywhere - and I think logs are better for this.

Comment 1

[Ed Morley [:emorley]]

At some point in the future when we post artifacts to S3, we'll just be storing the URLs to the artifacts and so the schema for the job_artifact table and job_log_url tables will be even similar - and by removing this file even more so.

Comment 2

[Ed Morley [:emorley]]

s/file/field/

Comment 3

[Ed Morley [:emorley]]

Attachment: Remove job_log_url.parse_timestamp

Comment 4

[Ed Morley [:emorley]]

Once this lands & is deployed, I'll do a:

manage.py run_sql -s "ALTER TABLE job_log_url DROP COLUMN parse_timestamp;"

(according to http://dev.mysql.com/doc/refman/5.1/en/alter-table.html , the index will be automatically removed when I remove the field)

...on stage/prod.

Though given the size of the job_log_url table, I may wait to do this at the same time as the job_log_url parts of bug 1178395, since I presume it can remove both columns at the same time.

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/49d4dfc59d399d3ef6499db5695200c03f41ac8d
Bug 1178389 - Remove job_log_url.parse_timestamp

Since it's unused.