1178395 - Remove the active_status field from most tables

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P4)

Description

[Ed Morley [:emorley]]

Since iirc it's not used anywhere apart from the repository table and the resultset table (for handling missing resultsets).

The intention was to use it to handle data expiration, but we already do per table deletes to avoid the perf issues of cascade deletes (and not using active_status).

In addition, even on the tables where we want to keep it, let's have 2 states (eg "active", "onhold") not three ("active", "onhold", "deleted").

Comment 1

[Ed Morley [:emorley]]

We may end up using active_status as part of bug 1042077, so leaving this for now.

Comment 2

[William Lachance (:wlach)]

Bug 1282907 took this property out from a bunch of tables.

Comment 3

[William Lachance (:wlach)]

While working on adding memcache caching for our django models, I was getting errors for some queries being too large (e.g. the jobtype table). While that has other primary causes (and can be worked around by enabling pylibmc compression), it does make me feel like we should just bite the bullet and remove these fields from our reference data models (except for repository, where we do use the value). I'll take this.

Comment 4

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1178395 > mozilla:master

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/277b3c3b7ae39bb1076847a2e52053cef1217d65
Bug 1178395 - Remove active status from most reference data tables (#1809)

The field is never updated or used in anything but repository, so let's just
take them out for now.

Comment 6

[William Lachance (:wlach)]

(In reply to Ed Morley [:emorley] from comment #0)

> In addition, even on the tables where we want to keep it, let's have 2
> states (eg "active", "onhold") not three ("active", "onhold", "deleted").

Yeah, we could even consider switching to a boolean called "active" for the one remaining table that needs it (repository). To be honest though, I'd be inclined to just leave it as is. It's not really doing any harm being the way it is (it's a very small table).