1282907 - NamedModel instances aren't unique

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[William Lachance (:wlach)]

The NamedModel base class doesn't work particularly well. It has no uniqueness constraint on the "name" field which means that updating instances of this model using django's get_or_create is potentially racey.

Also, most of the fields aren't relevant in most cases.

I think we'd be best off fixing this simply by removing NamedModel and just defining the things we care about in each ORM class. The name field should always be unique.

Comment 1

[William Lachance (:wlach)]

Actually I think the NamedModel class is useful, now that I think about it. We just don't want all its properties in most cases (and 'name' should have the unique constraint). Let's fix that.

Comment 2

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1282907 > mozilla:master

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/f86dae6e61f7868fa53007c55cccbab6888140dd
Bug 1282907 - Fix named models to be more sane (#1624)

* Remove unused members from NamedModel (define in subclass where really
  needed)
* Enforce uniqueness on name properties