Closed Bug 1178703 Opened 9 years ago Closed 9 years ago

Regression: Home Panels provided by addons show no content

Categories

(Firefox for Android Graveyard :: Awesomescreen, defect)

All
Android
defect
Not set
normal

Tracking

(firefox41 fixed, firefox42 fixed)

RESOLVED FIXED
Tracking Status
firefox41 --- fixed
firefox42 --- fixed

People

(Reporter: sebastian, Assigned: sebastian)

References

Details

(Keywords: regression)

STR:
* Install addon that adds a home panel (e.g. wikipedia-panel, catfacts, ..)
* Open new tab
* Swipe to new panel added by addon

Expected results: Addon content should be displayed in new panel
Actual results: "No content could be found for this panel." is displayed.

This regression is only in fx-team right now. Nightly builds are not affected (yet).
It seems like the regression has been introduced with this changeset (Bug 1177774):
http://hg.mozilla.org/mozilla-central/rev/8cab4b5abe7f

NI, Michael: The change seems to be related to the eslint issues - but I can't find the actual output of eslint in Bug 1177774.
Flags: needinfo?(michael.l.comella)
Oops, I accidentally linked the wrong changeset in the comment above. This is the regressing change:
https://hg.mozilla.org/integration/fx-team/rev/c084008baf54

But this change is also in mozilla-central and should affect Nightly too (but it does not!):
https://hg.mozilla.org/mozilla-central/rev/c084008baf54
See Also: → 1178739
Reverting this change only fixes the wikipedia-panel. There's another error that also affects Nightly. I opened bug 1178739 for that.
Maybe this will be fixed by the backout I did for bug 1178739? I would be surprised if fixing the generator syntax led to this.
Blocks: 1177774
Keywords: regression
(In reply to :Margaret Leibovic from comment #4)
> Maybe this will be fixed by the backout I did for bug 1178739? I would be
> surprised if fixing the generator syntax led to this.

I'm not sure why this is happening but I need to back out this change too. Otherwise add-on panels will remain empty (After app install and add-on install).
(In reply to :Sebastian Kaspari from comment #6)
> https://hg.mozilla.org/integration/fx-team/rev/0e512063822a

I did a backout as this is affecting Nightly now and it's quite hard to develop things while keeping track of a local-only backout.
(In reply to :Sebastian Kaspari from comment #7)
> (In reply to :Sebastian Kaspari from comment #6)
> > https://hg.mozilla.org/integration/fx-team/rev/0e512063822a
> 
> I did a backout as this is affecting Nightly now and it's quite hard to
> develop things while keeping track of a local-only backout.

That's the right call. We should always feel free to back things out if they caused problems. Do we also need to uplift this backout to aurora? You should be able to just push it to aurora as well (backouts don't need approval).
I got it: https://hg.mozilla.org/releases/mozilla-aurora/rev/7b0e3c02591f

Thanks for staying on top of this, Sebastian! :)

(In reply to :Margaret Leibovic from comment #4)
> I would be surprised if fixing the generator syntax led to this.

Yeah, this is unexpected. :\
Unassigning: The regression is fixed for now. Maybe we should create a follow-up for fixing the eslint/generator errors?
Assignee: s.kaspari → nobody
Status: ASSIGNED → NEW
This was backed out from 42 in comment 6.

(In reply to :Sebastian Kaspari from comment #10)
> Unassigning: The regression is fixed for now.

Reassigning - you were responsible for fixing the issue with the backout. :)

> Maybe we should create a
> follow-up for fixing the eslint/generator errors?

Good idea: bug 1185578. Thanks for staying on top of this.
Assignee: nobody → s.kaspari
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(michael.l.comella)
Resolution: --- → FIXED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.