Closed
Bug 1179093
Opened 9 years ago
Closed 9 years ago
ContentEventHandler::mSelection should be nsRefPtr<Selection>
Categories
(Core :: DOM: UI Events & Focus Handling, defect)
Core
DOM: UI Events & Focus Handling
Tracking
()
RESOLVED
FIXED
mozilla42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
Attachments
(1 file)
|
11.90 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•9 years ago
|
||
This makes ContentEventHandler simpler. I want nsISelection::AsSelection() for guaranteeing that there is no other implementation of nsISelection, though.
Attachment #8628196 -
Flags: review?(bugs)
|
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8628196 [details] [diff] [review] Patch Oops, the forward declaration of dom::Selection in ContentEventHandler.h. So, I'll remove it before landing, please ignore it.
|
||
Updated•9 years ago
|
Attachment #8628196 -
Flags: review?(bugs) → review+
|
||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/237d69ce33f1
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
|
||
Updated•5 years ago
|
Component: Event Handling → User events and focus handling
You need to log in
before you can comment on or make changes to this bug.
Description
•