1179090 - ContentEventHandler should assume that the selection range is [0-0] when there is not selection range

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

When WidgetQueryContentEvent queries the whole contents of the document, there may be no selection range. In such case, ContentEventHandler should assume that there is a selection range [0-0].

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

See comment 0 and the comment in this patch for the detail.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8628576 [details] [diff] [review]
Patch

>+  if (!mSelection->RangeCount()) {
>+    // If there is no selection range, we should compute the selection root
>+    // with ancestor limiter and root content of the document.
compute the selection root from ancestor limiter or root content of the document
(I think)


>+    rv = mSelection->GetAncestorLimiter(getter_AddRefs(mRootContent));
>+    if (NS_WARN_IF(NS_FAILED(rv))) {
>+      return NS_ERROR_FAILURE;
>+    }
>+    if (!mRootContent) {
>+      mRootContent = mPresShell->GetDocument()->GetRootElement();
>+      if (NS_WARN_IF(!mRootContent)) {
>+        // Although, this is possible in XML/XHTML document.  However,
>+        // ContentEventHandler won't support such rare case for now.
HTML documents may not have root element after
document.removeChild(document.documentElement);
So, perhaps just drop the comment.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/20245e58fd57

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/20245e58fd57