1179156 - [Browser]The image option can't pop up when you long tap an image.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[Lance（leave from Mozilla）]

Attachment: logcat_0400.txt

[1.Description]:
[Flame v2.2 & v3.0][Nexus 5 v2.2 & v3.0][Browser]When you long tap the image at Add to home screen view, the image option can't pop up.
Found time: 04:00
See attachment: 0400.3gp and logcat_0400.txt

[2.Testing Steps]: 
1.Launch Browser.
2.View some websites.
3.Tap Menu -> "Add to home screen".
4.Long tap the image.
5.Tap "x" to exit.

[3.Expected Result]: 
4.The image option should display and function use normally.
5.Device should back to website.

[4.Actual Result]: 
4.The image option can't display.
5.The image option will display, but it will back to website when you tap any option.

[5.Reproduction build]: 
Device: Flame 2.2 version(Affected):
Build ID               20150630162500
Gaia Revision          bd386f346eb1591fddbc84bf034b22700e7e2a58
Gaia Date              2015-06-30 15:53:15
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/f16c1125b9d6
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150630.200238
Firmware Date          Tue Jun 30 20:02:49 EDT 2015
Bootloader             L1TC000118D0

Device: Flame master version(Affected):
Build ID               20150630160220
Gaia Revision          5997b406e77ea726fbd9047057a1c3504f6cd6d4
Gaia Date              2015-06-30 01:48:01
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/291614a686f1
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150630.193722
Firmware Date          Tue Jun 30 19:37:34 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus 5_2.2 version(Affected):
Build ID               20150630162500
Gaia Revision          bd386f346eb1591fddbc84bf034b22700e7e2a58
Gaia Date              2015-06-30 15:53:15
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/f16c1125b9d6
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150630.200214
Firmware Date          Tue Jun 30 20:02:30 EDT 2015
Bootloader             HHZ12f

Device: Nexus 5_master version(Affected):
Build ID               20150630010206
Gaia Revision          27fe0f4261e3685187769411f2f74cff19287b19
Gaia Date              2015-06-29 14:29:00
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/aad95360a002
Gecko Version          42.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150630.042823
Firmware Date          Tue Jun 30 04:28:43 EDT 2015
Bootloader             HHZ12f

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

Comment 1

[Lance（leave from Mozilla）]

Attachment: 0400.3GP

Comment 2

[Hermes Cheng (inactive after July 27, 2015)]

[Blocking Requested - why for this release]:

It is a good finding. Change component to windows mgmt.
Tim, could you please help find someone to solve this issue?

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

You should needinfo Etienne or Gergor for window mgmt issues.

That said, I don't think this is a window mgmt issue (browser chrome maybe?)

Comment 4

[Gregor Wagner [:gwagner]]

Ben, can you take a look here?

Comment 5

[Boris Chiou [:boris]]

I took a look at this bug and reproduced this on my z3c. It looks like the z-order of context menu is not correct.

Comment 6

[Gregor Wagner [:gwagner]]

Thanks for taking this bug Boris!

Comment 7

[Boris Chiou [:boris]]

After cherry-picking attachment 8646838 [details] [diff] [review] (in bug 952456), I can see the popup context menu. However, "save image" doesn't work and I got this error message:
[JavaScript Error: "NS_ERROR_MALFORMED_URI: Component returned failure code: 0x804b000a (NS_ERROR_MALFORMED_URI) [nsIIOService2.newURI]" {file: "jar:file:///system/b2g/omni.ja!/components/BrowserElementParent.js" line: 738}]
I will focus on this problem.

Comment 8

[Boris Chiou [:boris]]

(In reply to Boris Chiou [:boris] from comment #7)
> After cherry-picking attachment 8646838 [details] [diff] [review] (in bug
> 952456), I can see the popup context menu. However, "save image" doesn't
> work and I got this error message:
> [JavaScript Error: "NS_ERROR_MALFORMED_URI: Component returned failure code:
> 0x804b000a (NS_ERROR_MALFORMED_URI) [nsIIOService2.newURI]" {file:
> "jar:file:///system/b2g/omni.ja!/components/BrowserElementParent.js" line:
> 738}]
> I will focus on this problem.

One possible reason according to my investigation:
The url of the bookmark icon is an empty string while the context menu was being created, so 'save image' and 'copy image' cannot work properly. Maybe we pass the wrong url from BrowserElementChildPreload.

Comment 9

[GitHub Autolander Bot]

Attachment: [gaia] BorisChiou:Bug1179156 > mozilla-b2g:master

Comment 10

[Boris Chiou [:boris]]

(In reply to Autolander from comment #9)
> Created attachment 8651711 [details] [review]
> [gaia] BorisChiou:Bug1179156 > mozilla-b2g:master

This bug is due to empty 'src' attribute in the img tag.
We render icon images by css backgroundImage,
(http://mxr.mozilla.org/gaia/source/shared/js/homescreens/icon.js#118)
so I think we shouldn't support long tap on the bookmark icon. (In other words, let's make it uncopyable)

Comment 11

[Ben Francis [:benfrancis]]

Comment on attachment 8651711 [details] [review]
[gaia] BorisChiou:Bug1179156 > mozilla-b2g:master

Thanks Boris!

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/250c2dfa9cd6eb6ce5b7162e5f53a3b6a33c3aef

Comment 13

[Norry.L.F(Leave from Mozilla)]

Hi Shally,

Please help to verify this bug, thanks. :)

Comment 14

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0.

Actual results: When long tapping the image and tapping "x", the image option menu will not pop up, the bookmark icon is uncopyable.
See attachment: verify_FlameKK_v2.5.3gp
Reproduce rate: 0/10


Device: Flame KK 2.5 (Pass)
Build ID               20150831150202
Gaia Revision          c80e8ff25425b007181fd6e3de0500a0358fab37
Gaia Date              2015-08-31 16:35:09
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/cafb1c90f794a73100a8f0afb9fe3301df0f2bde
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150831.183117
Firmware Date          Mon Aug 31 18:31:30 EDT 2015
Bootloader             L1TC000118D0
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 (Pass)
Build ID               20150831201354
Gaia Revision          c80e8ff25425b007181fd6e3de0500a0358fab37
Gaia Date              2015-08-31 16:35:09
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/cafb1c90f794a73100a8f0afb9fe3301df0f2bde
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150831.193718
Firmware Date          Mon Aug 31 19:37:26 UTC 2015
Bootloader             s1

----------------------------------------------------------------------------------------------------
Note: After step 4, the url text/name on "Add to Home" page will be optional with blue bubble, but the text selection options (cut, copy, paste, select all) does not appear. I will submit this bug later.

Comment 15

[Shally Li（leave from Mozilla）]

Attachment: verify_Flamekk_v2.5.3gp