1200517 - [Browser]The text selection options (Copy, Select all) does not appear on "Add to Home" page.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Shally Li（leave from Mozilla）]

[1.Description]:
According to comment 14 in Bug 1179156, this bug is filed.
[Aries KK v2.5][Flame KK v2.5][Browser]Long tapping the bookmark icon/address/name on "Add to Home" page, a part of the address/name is highlighted with blue bubble, but the text selection options (Copy, Select all) does not appear and the text selection function can't work.

Found at: 02:08
Attach: Flamekk_v2.5.3gp and logcat_0208.txt.

[2.Testing Steps]: 
1.Launch Browser.
2.Open a website.
3.Tap Menu -> "Add to home screen".
4.Long tap the bookmark icon.

[3.Expected Result]: 
4-1. When long tapping the bookmark icon, it should have no any response. 
4-2. When the bookmark's address/name on "Add to Home" page is highlighted with blue bubble, the text selection options (Copy, Select all) should appear.

[4.Actual Result]: 
4. A part of the bookmark's address/name is highlighted with blue bubble, but the text selection options (Copy, Select all) does not appear.

[5.Reproduction build]: 
Device: Flame KK 2.2 (Unaffected) 
Build ID               20150831032501
Gaia Revision          335cd8e79c20f8d8e93a6efc9b97cc0ec17b5a46
Gaia Date              2015-08-14 19:06:41
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/16d864d163de
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150831.065145
Firmware Date          Mon Aug 31 06:51:55 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame KK 2.5 (Affected)
Build ID               20150831150202
Gaia Revision          c80e8ff25425b007181fd6e3de0500a0358fab37
Gaia Date              2015-08-31 16:35:09
Gecko Revision         https://hg.mozilla.org/mozilla-

central/rev/cafb1c90f794a73100a8f0afb9fe3301df0f2bde
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150831.183117
Firmware Date          Mon Aug 31 18:31:30 EDT 2015
Bootloader             L1TC000118D0
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 (Affected)
Build ID               20150831201354
Gaia Revision          c80e8ff25425b007181fd6e3de0500a0358fab37
Gaia Date              2015-08-31 16:35:09
Gecko Revision         https://hg.mozilla.org/mozilla-

central/rev/cafb1c90f794a73100a8f0afb9fe3301df0f2bde
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150831.193718
Firmware Date          Mon Aug 31 19:37:26 UTC 2015
Bootloader             s1


[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

Comment 1

[Shally Li（leave from Mozilla）]

Attachment: logcat_0208.txt

Comment 2

[Shally Li（leave from Mozilla）]

Attachment: Flamekk_v2.5.3gp

Comment 3

[Jeremy Chen ([e-mail])]

Looks like a z-index problem. An appWindow "ActivityWindow" with z-index:65536 is created, so the selection dialog with z-index:2 is not shown. I'm going to verify why 2.2 is not affected first, then try to find a solution.

Comment 4

[Gregor Wagner [:gwagner]]

Are you going to take this bug Jeremy?

Comment 5

[Jeremy Chen ([e-mail])]

(In reply to Gregor Wagner [:gwagner] from comment #4)
> Are you going to take this bug Jeremy?

Yes. I'm working on it.

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] chenpighead:1200517 > mozilla-b2g:master

Comment 7

[Jeremy Chen ([e-mail])]

Comment on attachment 8655788 [details] [review]
[gaia] chenpighead:1200517 > mozilla-b2g:master

The main difference between 2.2 and 2.5 is that 2.2 uses the old text-selection-dialog with only one universal bubble attached on screen div; however, 2.5 uses the new app-text-selection-dialog to attach one per-app bubble on each appWindow.

When using add-link-to-home-screen, an ActivityWindow is created w/ z-index = 65536 under bookmark app. So the app-based text-selection-dialog under bookmark app w/ z-index = 2 is covered, which looks like a no show.

In the old text-selection-dialog, changing its z-index may easily affect other components appearance. In the new app based version, changing z-index is more reliable since it would be bounded by its parent appWindow. Therefore, I think changing the z-index of app-based text-selection-dialog could be a fix.

Tim, could you help review this? Thanks.

Comment 8

[Jeremy Chen ([e-mail])]

The only try fail is caused by Bug 1121463, since the gecko patch is not landed yet. So, please check in the patch. Thanks.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/351deafbae1eecce8b3bfb342fbb2f80ffb6a320

Comment 10

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0.

Actual results: The text selection options (Copy, Select all) appear and work normally on "Add to Home" page.
See attachment: verified_FlameKK_v2.5.3gp
Reproduce rate: 0/10


Device: Flame KK 2.5 (Pass)
Build ID               20150905150219
Gaia Revision          03be7d8918bed58c92a40bba211bbbc97a0e516a
Gaia Date              2015-09-04 11:56:30
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/139446daedab3d00b9f0faba25e1e82191c8c8d1
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150905.183746
Firmware Date          Sat Sep  5 18:38:03 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 (Pass)
Build ID               20150905112803
Gaia Revision          03be7d8918bed58c92a40bba211bbbc97a0e516a
Gaia Date              2015-09-04 11:56:30
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/139446daedab3d00b9f0faba25e1e82191c8c8d1
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150905.105729
Firmware Date          Sat Sep  5 10:57:37 UTC 2015
Bootloader             s1

Comment 11

[Shally Li（leave from Mozilla）]

Attachment: verified_FlameKK_v2.5.3gp

Comment 12

[Autumn.Qiu(Leave from Mozilla)]

Attachment: Verified_FlameKK_v2.5.png

This bug has been verified as "pass" on the latest build of Flame KK v2.5 by the STR in comment 0.

Actual results: After changing to Arabic,SHB does not overlap any text in FM radio.
See attachment: Verified_FlameKK_v2.5.png
Reproduce rate: 0/10

Device: Flame KK 2.5 (Pass)
Build ID               20150905150219
Gaia Revision          03be7d8918bed58c92a40bba211bbbc97a0e516a
Gaia Date              2015-09-04 11:56:30
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/139446daedab3d00b9f0faba25e1e82191c8c8d1
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150905.183746
Firmware Date          Sat Sep  5 18:38:03 EDT 2015