Update ANGLE from chromium/2214 to chromium/2466

RESOLVED FIXED in Firefox 44

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: milan, Assigned: jrmuizel)

Tracking

(Depends on: 1 bug, Blocks: 1 bug)

Trunk
mozilla44
Unspecified
All
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox43 unaffected, firefox44 fixed)

Details

(Whiteboard: [gfx-noted])

(Reporter)

Description

2 years ago
Make sure we touch README.mozilla so that we can track what version we're on.
(Reporter)

Updated

2 years ago
OS: Unspecified → All
(Reporter)

Updated

2 years ago
See Also: → bug 1036068
(Reporter)

Comment 1

2 years ago
I don't really want to wait for our patches to get uplifted, but lets see how the timing goes.  If we do have local patches, I'd like the landing of this to be in a three part patch set - the first one to undo our changes and get angle back to what it was in 2214; the second to just update to 2403; the third one to add our changes on top.
Whiteboard: [gfx-noted]
(Reporter)

Updated

2 years ago
Blocks: 1050640
(Reporter)

Comment 2

2 years ago
We should also investigate the flags ANGLE has and see if we're doing the right thing.
Component: Graphics → Canvas: WebGL
(Reporter)

Comment 3

2 years ago
Stuff in WebGLShaderValidator.cpp, ChooseValidatorCompileOptions function.
(In reply to Milan Sreckovic [:milan] from comment #2)
> We should also investigate the flags ANGLE has and see if we're doing the
> right thing.

I did do this in the past (maybe when I did the WebGLShaderValidator code), and cross-compared what we do with WRT Chromium.
(Reporter)

Updated

2 years ago
Blocks: 1186205

Updated

2 years ago
Blocks: 1188167
(Assignee)

Comment 5

2 years ago
WIP in https://github.com/jrmuizel/angle/tree/minimal-changes-on-chrome-2466
(Assignee)

Updated

2 years ago
Depends on: 1191042
(Assignee)

Updated

2 years ago
Depends on: 1149728

Updated

2 years ago
Blocks: 1109708
(Assignee)

Updated

2 years ago
Blocks: 1195259

Updated

2 years ago
Blocks: 1136411
(Reporter)

Updated

2 years ago
Assignee: nobody → jmuizelaar
(Assignee)

Updated

2 years ago
Summary: Update ANGLE from chromium/2214 to chromium/2403 → Update ANGLE from chromium/2214 to chromium/2466
(Assignee)

Updated

2 years ago
Blocks: 1207288
(Assignee)

Comment 6

2 years ago
Try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d9cbb41bacba
(Assignee)

Updated

2 years ago
Blocks: 1208630
(Assignee)

Updated

2 years ago
No longer blocks: 1208630
Depends on: 1208630

Comment 7

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/56db457aef33
https://hg.mozilla.org/mozilla-central/rev/56db457aef33
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44

Comment 9

2 years ago
There is a performance impact observed after this update, marked down as https://bugzilla.mozilla.org/show_bug.cgi?id=1210683.
(Assignee)

Updated

2 years ago
Depends on: 1211241
(Assignee)

Updated

2 years ago
Blocks: 1212878
Marking affected for 43.
status-firefox43: --- → affected
(Assignee)

Comment 11

2 years ago
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #10)
> Marking affected for 43.

That doesn't make sense to me. This didn't land until 44.
Flags: needinfo?(lhenry)
I'll find you on irc, there was a reference to this from another bug.
Flags: needinfo?(lhenry)
I misunderstood, thanks for the explanation Jeff!
status-firefox42: affected → ---
status-firefox43: affected → unaffected
Blocks: 1186621
You need to log in before you can comment on or make changes to this bug.