Closed Bug 1179300 Opened 5 years ago Closed 5 years ago
Disable dynamic UA override updates (and add back the local youtube override)
For some reason ua-update.json isn't doing what it should be doing and Youtube is broken in Nightly and Aurora. Let's turn it off, fix Youtube and figure out what's going on.
[Tracking Requested - why for this release]: Requesting tracking because Youtube is broken. That's no good.
OK, rebuilding with this patch I've cleared data and verified that Youtube works. I even uninstalled a few times and re-installed and it still works.
Attachment #8628328 - Flags: review?(margaret.leibovic) → review+
Thanks for the quick review Margaret. Sheriffs, no Try run because we're just changing one pref value and adding an UA override pref to mobile.js. Building locally shows that it works as expected.
Comment on attachment 8628328 [details] [diff] [review] 1179300-Disable-dynamic-UA-updates-and-add-local.patch Approval Request Comment [Feature/regressing bug #]: Dyanamic UA overrides, updated from our CDN. Bug 1175305. [User impact if declined]: Youtube.com will be broken for Aurora (Mobile) users. [Describe test coverage new/current, TreeHerder]: None. Dynamic UA override tests are disabled. Part of re-enabling this feature will be to figure out exactly why. [Risks and why]: Little to no risk. Just flipping a pref, and moving a Youtube override from one place (dynamic ua CDN) to another (local pref). [String/UUID change made/needed]: None
tracking-fennec: ? → 41+
Comment on attachment 8628328 [details] [diff] [review] 1179300-Disable-dynamic-UA-updates-and-add-local.patch Approving for uplift to Aurora, this has been on m-c for a week with no issues and is low-risk.
Attachment #8628328 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Thanks for landing this Ryan.
You need to log in before you can comment on or make changes to this bug.