1179362 - "You have been signed in" in marketplace app is missing trailing period.

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P3)

Description

[Sheeri Cabral [:sheeri]]

"You have been signed in" in marketplace app is missing trailing period.

Comment 1

[Trishul]

I don't know if I am doing something wrong, but I am unable to find string "You have been signed in" in complete prject, strange?

Comment 2

[Ram Dayal Vaishnav [:ram]]

I was able to re-produce this bug at desktop site. This message pops up when we log in into the marketplace website. 

Wil, is this a valid bug, because I see other strings also without trailing periods like "Your review was successfully edited"

Comment 3

[Amy Tsay [:amyt]]

NI from Liz, since Wil is out.

Comment 4

[Elizabeth Hunt[:ezoehunt]]

Ram is correct. The use of trailing period is currently inconsistent across Marketplace. 

In the next iteration of MOW, we're cleaning up many of the "toasts" to be sentences with trailing periods. But we didn't include the sign in/out ones in that clump of work.

We'd like the sign in/out toasts to include a trailing period. So sure go ahead, and add trailing period to this one!

Comment 5

[Ram Dayal Vaishnav [:ram]]

Marking this as good-first-bug, feel free to pick this up. Good Luck!

Fireplace docuentation - https://marketplace-frontend.readthedocs.org/en/latest/index.html

Comment 6

[Sirjan Kaur]

Hi,

I would like to work on this bug. Can you please assign this to me?

Thanks,
Sirjan

Comment 7

[Ram Dayal Vaishnav [:ram]]

Sure Sirjan. Assigning you to this bug.

For any help you can refer to the documentation at http://marketplace.readthedocs.org/, or ask in #marketplace irc channel.

Thanks!

Comment 8

[Sirjan Kaur]

Hi,

I have made changes in the file and tested it in the local instance. But the files are not being tracked by Git.

Comment 9

[Sirjan Kaur]

The files that I made changes in are : 
1. ~/fireplace/node-modules/marketplace-gulp/node-modules/commonplace/dist/core/login.js
2. ~/fireplace/bower_components/marketplace-core-modules/core/login.js

I have added the trailing period in signinNotification function and signoutNotification function in both of these files.

Comment 10

[Mark Striemer [:mstriemer]]

This change should be made to the marketplace-core-modules repository [1] which handles our common frontend code like login/logout.

To test these changes locally you can use `bower link`[2] as documented for Marketplace [3]. 

[1] https://github.com/mozilla/marketplace-core-modules
[2] http://bower.io/docs/api/#link
[3] https://marketplace-frontend.readthedocs.org/en/latest/topics/developing-components.html#development-and-testing-workflow

Comment 11

[Ram Dayal Vaishnav [:ram]]

Hi Sirjan,

Please make above code changes, let us know if you face any issues.

Comment 12

[Andreas Wagner [:TheOne] [use NI]]

Sirjan, there hasn't been any activity on this bug for a while. Are you still working on it?

Comment 13

[Mohammad Shahbaz Alam [:shahbaz17]]

i have fixed this here. will this help https://github.com/mozilla/marketplace-core-modules/pull/50

Comment 14

[Mohammad Shahbaz Alam [:shahbaz17]]

https://patch-diff.githubusercontent.com/raw/mozilla/marketplace-core-modules/pull/50.patch

Comment 15

[Ram Dayal Vaishnav [:ram]]

Shahbaz, lets wait for some reviewer to look into your patch. Assigning this bug to you, thanks :)

Comment 16

[Mohammad Shahbaz Alam [:shahbaz17]]

can you change my email id from [e-mail] to [e-mail] bcoz i don't use that email id anymore..

Comment 17

[Mark Striemer [:mstriemer]]

https://github.com/mozilla/marketplace-core-modules/commit/fbaa12b0b804ad65577e89e7dd6739d5ae7b9953

Fireplace PR to merge after to tag to allow more time for translations: https://github.com/mozilla/fireplace/pull/1453

Comment 18

[Mohammad Shahbaz Alam [:shahbaz17]]

Is this bug fixed?

Comment 19

[Ram Dayal Vaishnav [:ram]]

(In reply to shahbazalam17feb from comment #18)
> Is this bug fixed?

Hi Mark, can you please confirm this?

Comment 20

[Andreas Wagner [:TheOne] [use NI]]

Marking as FIXED as per comment 17.

Comment 21

[Mark Striemer [:mstriemer]]

Merged to fireplace in https://github.com/mozilla/fireplace/commit/e52029d2cdce5c9889ae71a2bbc6ca76eb73c560