Closed
Bug 1179713
Opened 9 years ago
Closed 9 years ago
Follow up to Bug 1175067 - fix the manifest of bluetooth2 marionette test set.
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(firefox42 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: jaliu, Assigned: jaliu)
References
Details
Attachments
(1 file, 1 obsolete file)
1007 bytes,
patch
|
Details | Diff | Splinter Review |
"disabled = xxxxx" statement should be added *below* the test that we want to disable.
It's a follow up bug of https://bugzilla.mozilla.org/show_bug.cgi?id=1175067#c9.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jaliu
Assignee | ||
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=70f040427f8a&exclusion_profile=false
The tests were skipped on treeherder correctly.
> TEST-SKIP | test_dom_BluetoothManager_API2.js | took 0ms
> TEST-SKIP | test_dom_BluetoothAdapter_enable_API2.js | took 3ms
> TEST-SKIP | test_dom_BluetoothAdapter_setters_API2.js | took 1ms
> TEST-SKIP | test_dom_BluetoothAdapter_discovery_API2.js | took 1ms
> TEST-SKIP | test_dom_BluetoothDevice_API2.js | took 1ms
> TEST-SKIP | test_dom_BluetoothAdapter_pair_API2.js | took 0ms
Assignee | ||
Updated•9 years ago
|
Attachment #8628741 -
Flags: review?(btian)
Comment 3•9 years ago
|
||
Comment on attachment 8628741 [details] [diff] [review]
Fix the manifest of bluetooth2 marionette test set. (v1)
Review of attachment 8628741 [details] [diff] [review]:
-----------------------------------------------------------------
r=me with comment addressed.
::: dom/bluetooth/bluetooth2/tests/marionette/manifest.ini
@@ +13,5 @@
> disabled = Bug 1175389
> [test_dom_BluetoothDevice_API2.js]
> disabled = Bug 1175389
> [test_dom_BluetoothAdapter_pair_API2.js]
> +disabled = Bug 1175389
Please leave comment to remind us next time.
Attachment #8628741 -
Flags: review?(btian) → review+
Assignee | ||
Comment 4•9 years ago
|
||
- Revise previous patch based on #Comment 3
Thank Ben for reviewing the patch.
Attachment #8628741 -
Attachment is obsolete: true
You need to log in
before you can comment on or make changes to this bug.
Description
•