Closed Bug 1179915 Opened 9 years ago Closed 9 years ago

[Build 22] Crash in Client.HomePanelViewController

Categories

(Firefox for iOS :: General, defect)

ARM
iOS
defect
Not set
critical

Tracking

()

RESOLVED FIXED
Tracking Status
fxios + ---

People

(Reporter: aaronmt, Assigned: fluffyemily)

Details

(Keywords: crash)

Attachments

(1 file)

47 bytes, text/x-github-pull-request
sleroux
: review+
Details | Review
Client: function signature specialization <Arg[1] = Owned To Guaranteed> of Client.HomePanelViewController.selectedButtonIndex.didset : Swift.Int? + 1680

This is in the XCode organizer for Build #22.
Assignee: nobody → etoop
Status: NEW → ASSIGNED
Status update?
Flags: needinfo?(etoop)
Attached file Pull request
Flags: needinfo?(etoop)
Attachment #8638586 - Flags: review?(jhugman)
Tried to open up the suspect code in an attempt to figure out more clearly where the problem is
Attachment #8638586 - Flags: review?(jhugman) → review?(sleroux)
Comment on attachment 8638586 [details] [review]
Pull request

I think this is the same bug as https://bugzilla.mozilla.org/show_bug.cgi?id=1183486. I also couldn't find any real code pointing to the problem but added a fix to the incorrect use of adding/removing child view controllers that we had. I think it would be useful to add this safer code in just in case that fix doesn't resolve the issue.
Attachment #8638586 - Flags: review?(sleroux) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: