1180011 - [tablet] url bar asset not updated for private browsing mode

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Regression from bug 864958.

Anthony, can I get updated assets?

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Tracking 41 to match bug 864958.

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Sorry, which icons are you referring to? Is this different to bug 1179479? 

Shouldn't we be tinting them rather than using new ones?

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Anthony Lam (:antlam) from comment #2)
> Sorry, which icons are you referring to?

https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/drawable-large-xhdpi-v11/url_bar_entry_default_pb.9.png
and
https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/drawable-large-xhdpi-v11/url_bar_entry_pressed_pb.9.png

> Is this different to bug 1179479? 

Yes.

> Shouldn't we be tinting them rather than using new ones?

They're multi-color so we can't. We might be able to do some clever color filter magic, but I don't think it's worth the time atm.

Comment 4

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: tablet_URL_pb.zip

Here ya go, try these. 

Worth noting that these are the ones we wanted to try that have no spacing between the bars and the the URL bar image.

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Anthony Lam (:antlam) from comment #4)
> Worth noting that these are the ones we wanted to try that have no spacing
> between the bars and the the URL bar image.

This only includes private assets - if we want to remove the whitespace, you have to include the non-private browsing assets as well (without the whitespace).

Also, it was 1px of whitespace removed, right? I need to adjust the layout files accordingly.

Comment 6

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: tablet_URL_pb_space.zip

Added the space back

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Screenshot (post patch)

LGTM.

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1180011 - Replace tablet private browsing url bar assets. r=margaret

Bug 1180011 - Replace tablet private browsing url bar assets. r=margaret

The phone assets were updated but the tablet assets were not.

Ideally, we'd merge these assets but let's not yak shave.

Comment 9

[:Margaret Leibovic]

Comment on attachment 8630681 [details]
MozReview Request: Bug 1180011 - Replace tablet private browsing url bar assets. r=margaret

https://reviewboard.mozilla.org/r/12781/#review11349

I can't read binary diffs, but sounds good to me!

Comment 10

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

url:        https://hg.mozilla.org/integration/fx-team/rev/5b0085aa462e21ac6082771ff5937e298044238a
changeset:  5b0085aa462e21ac6082771ff5937e298044238a
user:       Michael Comella <[e-mail]>
date:       Tue Jul 07 13:42:19 2015 -0700
description:
Bug 1180011 - Replace tablet private browsing url bar assets. r=margaret

The phone assets were updated but the tablet assets were not.

Ideally, we'd merge these assets but let's not yak shave.

Comment 11

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8630681 [details]
MozReview Request: Bug 1180011 - Replace tablet private browsing url bar assets. r=margaret

Approval Request Comment
[Feature/regressing bug #]: bug 864958
[User impact if declined]:
  Users on tablet will have the incorrect url bar color which makes the text contrast look amateur and causes the fading text background to appear (like bug 1179407).

[Describe test coverage new/current, TreeHerder]: Local
[Risks and why]: Low - we just replaced the private browsing assets with new ones. Worst case, the assets are the wrong size or are the wrong image and the appearance is unexpected.

[String/UUID change made/needed]: None

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5b0085aa462e

Comment 13

[Kate Glazko]

Comment on attachment 8630681 [details]
MozReview Request: Bug 1180011 - Replace tablet private browsing url bar assets. r=margaret

Approving for uplift to Aurora because low-risk assets change.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b99d8bfe7e77

Comment 15

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Backout 41, see bug 864958 comment 51 for motivations:
  https://hg.mozilla.org/releases/mozilla-aurora/rev/c4291c4d931f

I'll be backing out bug 864958 too so 41 will be unaffected.