1180111 - App description should be non-RTL property in Arabic view

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: Consumer Pages, defect, P4)

Description

[Atique Ahmed Ziad [:atiqueahmedziad]]

1. Go to- https://marketplace-dev.allizom.org?lang=ar
2. Go to any app details page
3. See the app description

Actual Result:
App description is in RTL

Expected Result:
As we don't translate the app description, so it should be non-RTL property.

Comment 1

[Atique Ahmed Ziad [:atiqueahmedziad]]

Working on it :)

Comment 2

[Mathieu Pillard [:mat]]

Not a trivial bug because the description *can* be translated by the developer - the frontend just does not know about it at the moment.

We call the API with ?lang=ar, the API returns just a string for translated fields, without exposing which language it is in - It could be arabic, it could be the default language for the app. The API can return an object instead of a string, with all the languages, but it does not do it when 'lang' is passed, for performance reasons. 

What we could do is have the API return an object with just the translation we are interested in, but that's a backward-incompatible change, not to be made lightly.

For an app that has "en-US" as its default language, and only french and english translations, it'd look like this:

- No lang parameter (no change):
  "description": { "en-US": "description in en", "fr": "description in french" }

- With lang=ar parameter (before proposed change, what we have now):
  "description": "description in en"

- With lang=ar parameter (after proposed change):
  "description": { "en-US": "description in en" }

Once we have this, the consumer pages could use the information in the template and the JavaScript code to figure out if it needs to add/remove rtl direction on the field.

Comment 3

[Atique Ahmed Ziad [:atiqueahmedziad]]

Thanks for the inputs :)

Comment 4

[Atique Ahmed Ziad [:atiqueahmedziad]]

Reopening on mstriemer's saying

Comment 5

[Atique Ahmed Ziad [:atiqueahmedziad]]

Please, someone take this bug :)

Comment 6

[Wil Clouser [:clouserw]]

(In reply to Mathieu Pillard [:mat] from comment #2)
> What we could do is have the API return an object with just the translation
> we are interested in, but that's a backward-incompatible change, not to be
> made lightly.

This sounds great

Comment 7

[Ayush Agrawal]

can i take this bug.

Comment 8

[Ram Dayal Vaishnav [:ram]]

Sure Ayush, Assigning this to you.

Comment 9

[Mathieu Pillard [:mat]]

Please note that it's really not a good first bug. It involves making modifications to the API, and use those modifications in the frontend templates/js/css code.

Comment 10

[Atique Ahmed Ziad [:atiqueahmedziad]]

Ayush, are you still working on it ?