1180132 - Android 2.3 / API 9 builds failing when RecyclerView is used

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

Bug 1171288 added the ability to build with RecyclerView. However a try run [1] for the first feature using RecyclerView (Bug 1176207) revealed that Android 2.3 / API 9 builds fail "error: package android.support.v7.widget does not exist".

Either the build changes do not affect builds for Android 2.3 or we are later excluding these files from the build.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=71912f4d2238

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

The RecyclerView library is defined in android.m4 inside the block of $MOZ_NATIVE_DEVICES. That's obviously wrong. It should be included regardless of $MOZ_NATIVE_DEVICES being set.

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7dad7d066686

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1180132 - android.m4: RecyclerView library should not be dependent on flag $MOZ_NATIVE_DEVICES. r?nalexander

Bug 1180132 - android.m4: RecyclerView library should not be dependent on flag $MOZ_NATIVE_DEVICES. r?nalexander

Comment 4

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8629392 [details]
MozReview Request: Bug 1180132 - android.m4: RecyclerView library should not be dependent on flag $MOZ_NATIVE_DEVICES. r?nalexander

https://reviewboard.mozilla.org/r/12605/#review11069

Ship It!

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/ed200dd9fd32

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/ed200dd9fd32