Closed Bug 1180132 Opened 5 years ago Closed 5 years ago

Android 2.3 / API 9 builds failing when RecyclerView is used

Categories

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Unspecified
Android
defect
Not set
normal

Tracking

(firefox42 fixed)

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: sebastian, Assigned: sebastian)

References

Details

Attachments

(1 file)

Bug 1171288 added the ability to build with RecyclerView. However a try run [1] for the first feature using RecyclerView (Bug 1176207) revealed that Android 2.3 / API 9 builds fail "error: package android.support.v7.widget does not exist".

Either the build changes do not affect builds for Android 2.3 or we are later excluding these files from the build.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=71912f4d2238
The RecyclerView library is defined in android.m4 inside the block of $MOZ_NATIVE_DEVICES. That's obviously wrong. It should be included regardless of $MOZ_NATIVE_DEVICES being set.
Bug 1180132 - android.m4: RecyclerView library should not be dependent on flag $MOZ_NATIVE_DEVICES. r?nalexander
Attachment #8629392 - Flags: review?(nalexander)
Status: NEW → ASSIGNED
Comment on attachment 8629392 [details]
MozReview Request: Bug 1180132 - android.m4: RecyclerView library should not be dependent on flag $MOZ_NATIVE_DEVICES. r?nalexander

https://reviewboard.mozilla.org/r/12605/#review11069

Ship It!
Attachment #8629392 - Flags: review?(nalexander) → review+
https://hg.mozilla.org/mozilla-central/rev/ed200dd9fd32
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 42 → mozilla42
You need to log in before you can comment on or make changes to this bug.