Closed Bug 1176207 Opened 9 years ago Closed 9 years ago

Replace GridView implementation in Home Panels with RecyclerView implementation

Categories

(Firefox for Android Graveyard :: Awesomescreen, defect)

Unspecified
Android
defect
Not set
normal

Tracking

(firefox42 fixed)

RESOLVED FIXED
Firefox 42
Tracking Status
firefox42 --- fixed

People

(Reporter: sebastian, Assigned: sebastian)

References

Details

Attachments

(1 file)

We want to add features like headers to grids (bug 1172136). Using RecyclerView instead of GridView will allow us to add this and more functionality by "just" swapping the LayoutManager class.
Status: NEW → ASSIGNED
Bug 1176207 - Replace PanelGridView with implementation based on RecyclerView. r?mhaigh
Attachment #8628833 - Flags: review?(mhaigh)
Depends on: 1180132
Attachment #8628833 - Flags: review?(mhaigh) → review+
Comment on attachment 8628833 [details]
MozReview Request: Bug 1176207 - Replace PanelGridView with implementation based on RecyclerView. r?mhaigh

https://reviewboard.mozilla.org/r/12481/#review11051

Looks good

::: mobile/android/base/home/PanelRecyclerViewAdapter.java:24
(Diff revision 1)
> +            // Wrap in a FrameLayout that will handle the highlight on touch

nit: remove empty line below and add one above

::: mobile/android/base/home/RecyclerViewItemClickListener.java:19
(Diff revision 1)
> +public class RecyclerViewItemClickListener implements RecyclerView.OnItemTouchListener, GestureDetector.OnGestureListener {

nit: on longer lines the accepted way of implementing multiple implemented classes is to line them up all, like this:

public class RecyclerViewItemClickListener implements RecyclerView.OnItemTouchListener, 
                                                      GestureDetector.OnGestureListener

::: mobile/android/base/home/SpacingDecoration.java:8
(Diff revision 1)
> +    private int horizontalSpacing;

final?

::: mobile/android/base/home/RecyclerViewItemClickListener.java:29
(Diff revision 1)
> +    public RecyclerViewItemClickListener(Context context,RecyclerView recyclerView, OnClickListener clickListener) {

nit: space before RecyclerView

::: mobile/android/base/home/RecyclerViewItemClickListener.java:25
(Diff revision 1)
> +    private OnClickListener clickListener;

Can these vars be made final?
Comment on attachment 8628833 [details]
MozReview Request: Bug 1176207 - Replace PanelGridView with implementation based on RecyclerView. r?mhaigh

Bug 1176207 - Replace PanelGridView with implementation based on RecyclerView. r?mhaigh
Attachment #8628833 - Flags: review+ → review?(mhaigh)
Comment on attachment 8628833 [details]
MozReview Request: Bug 1176207 - Replace PanelGridView with implementation based on RecyclerView. r?mhaigh

Fixed nits.
Attachment #8628833 - Flags: review?(mhaigh) → review+
https://hg.mozilla.org/mozilla-central/rev/de11b540c846
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: