1176207 - Replace GridView implementation in Home Panels with RecyclerView implementation

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

We want to add features like headers to grids (bug 1172136). Using RecyclerView instead of GridView will allow us to add this and more functionality by "just" swapping the LayoutManager class.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8fbd43b71c2c

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1176207 - Replace PanelGridView with implementation based on RecyclerView. r?mhaigh

Bug 1176207 - Replace PanelGridView with implementation based on RecyclerView. r?mhaigh

Comment 3

[Martyn Haigh (:mhaigh)]

Comment on attachment 8628833 [details]
MozReview Request: Bug 1176207 - Replace PanelGridView with implementation based on RecyclerView. r?mhaigh

https://reviewboard.mozilla.org/r/12481/#review11051

Looks good

::: mobile/android/base/home/PanelRecyclerViewAdapter.java:24
(Diff revision 1)
> +            // Wrap in a FrameLayout that will handle the highlight on touch

nit: remove empty line below and add one above

::: mobile/android/base/home/RecyclerViewItemClickListener.java:19
(Diff revision 1)
> +public class RecyclerViewItemClickListener implements RecyclerView.OnItemTouchListener, GestureDetector.OnGestureListener {

nit: on longer lines the accepted way of implementing multiple implemented classes is to line them up all, like this:

public class RecyclerViewItemClickListener implements RecyclerView.OnItemTouchListener, 
                                                      GestureDetector.OnGestureListener

::: mobile/android/base/home/SpacingDecoration.java:8
(Diff revision 1)
> +    private int horizontalSpacing;

final?

::: mobile/android/base/home/RecyclerViewItemClickListener.java:29
(Diff revision 1)
> +    public RecyclerViewItemClickListener(Context context,RecyclerView recyclerView, OnClickListener clickListener) {

nit: space before RecyclerView

::: mobile/android/base/home/RecyclerViewItemClickListener.java:25
(Diff revision 1)
> +    private OnClickListener clickListener;

Can these vars be made final?

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8628833 [details]
MozReview Request: Bug 1176207 - Replace PanelGridView with implementation based on RecyclerView. r?mhaigh

Bug 1176207 - Replace PanelGridView with implementation based on RecyclerView. r?mhaigh

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8628833 [details]
MozReview Request: Bug 1176207 - Replace PanelGridView with implementation based on RecyclerView. r?mhaigh

Fixed nits.

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=51be0a7d7adf

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/de11b540c846

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/de11b540c846