1180240 - ContentEventHandler::OnQuerySelectedText() should use mFirstSelectedRange if mSelection doesn't have selection range

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

By the fix of bug 1179090, ContentEventHandler assumes that there is a selection range [0-0] when there is not selection range actually.

On the other hand, in ContentEventHanldler::OnQuerySelectedText(), it uses mSelection->Get(Anchor|Focus)Node() for retrieving selection range. So, we should use mFirstSelectionRange if it doesn't return proper node.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8629882 [details] [diff] [review]
Patch

>+    NS_ASSERTION(mFirstSelectedRange->Collapsed(),
>+     "When mSelection doesn't have selection, mFirstSelectedRange must be "
>+     "collapsed");
nit, 2 spaces for indentation


>+    anchorNode = focusNode = mFirstSelectedRange->GetStartParent();
It is guaranteed that mFirstSelectedRange is always non-null when this method is run, right?

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Olli Pettay [:smaug] from comment #2)
> >+    anchorNode = focusNode = mFirstSelectedRange->GetStartParent();
> It is guaranteed that mFirstSelectedRange is always non-null when this
> method is run, right?

Yes. It's guaranteed at initializing the members:
http://mxr.mozilla.org/mozilla-central/source/dom/events/ContentEventHandler.cpp?rev=20245e58fd57&mark=108-111#85

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6629ba7c735a

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6629ba7c735a