Closed Bug 1180360 Opened 11 years ago Closed 10 years ago

Can't compose a message to a newsgroup from the header

Categories

(Thunderbird :: Message Reader UI, defect)

Product:
Thunderbird
Component:
Message Reader UI
Version:
38 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird40 wontfix, thunderbird41 fixed, thunderbird42 fixed, thunderbird43 fixed, thunderbird_esr3841+ fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 43.0
Tracking Flags:
Tracking Status
thunderbird40 --- wontfix
thunderbird41 --- fixed
thunderbird42 --- fixed
thunderbird43 --- fixed
thunderbird_esr38 41+ fixed

People

(Reporter: squib, Assigned: squib)

References

Details

(Keywords: regression, Whiteboard: [regression:TB38,TB39,TB40,TB41])

Attachments

(1 file)

Fix it
1.46 KB, patch
mkmelin
: review+
rkent
: approval-comm-aurora+
rkent
: approval-comm-beta+
rkent
: approval-comm-esr38+
Details | Diff | Splinter Review
Attached patch Fix it — — Splinter Review
Normally, in the message header, you can click a newsgroup name and select "Compose Message To" to open a new compose window. This is currently broken (on nightly and 38.0). Here's a patch. :rkent, I'm putting you down for review because you're the one who regressed it. :)
Attachment #8629551 - Flags: review?(rkent)
Actually, maybe it was JorgK who broke it, but you're assigned to the bug. Oh well.
Comment on attachment 8629551 [details] [diff] [review] Fix it Let's let Magnus deal with this.
Attachment #8629551 - Flags: review?(rkent) → review?(mkmelin+mozilla)
Whiteboard: [regression:TB38,TB39,TB40,TB41]
Version: unspecified → 38
Comment on attachment 8629551 [details] [diff] [review] Fix it Review of attachment 8629551 [details] [diff] [review]: ----------------------------------------------------------------- Sorry for the delay, LGTM! r=mkmelin
Attachment #8629551 - Flags: review?(mkmelin+mozilla) → review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/4265dff7d59960c5d7a274cfbf025667127a6bb9 Bug 1180360 - "Can't compose a message to a newsgroup from the header". r=mkmelin
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 43.0
Does this require uplift?
Flags: needinfo?(squibblyflabbetydoo)
(In reply to Jim Porter (:squib) from comment #1) > Actually, maybe it was JorgK who broke it, but you're assigned to the bug. > Oh well. Actually, Kent "improved" it, but I was shuffling/merging some patches on that bug, so it looks like it was me ;-) However, Kent did a great job back then, that was an absolutely urgent fix he landed. The person who really broke it shall remain nameless. It was the person behind the jsmime change who had sadly forgotten a few bits, which Kent then fixed, sadly only 97.5% optimally ;-)
Yes, this needs uplift to the 38 branch.
Flags: needinfo?(squibblyflabbetydoo)
Comment on attachment 8629551 [details] [diff] [review] Fix it [Approval Request Comment] Regression caused by (bug #): 1130248 Here you go.
Attachment #8629551 - Flags: approval-comm-esr38?
Attachment #8629551 - Flags: approval-comm-beta?
Attachment #8629551 - Flags: approval-comm-aurora?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: