11804 - Toolbar buttons need to toggle type-in state

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Simon Fraser [no longer active]]

When typing in bold text, you should be able to hit the bold button to change
to typing in non-bold. This doesn't work right now. We need to change the
type-in state from the buttons.

Comment 1

[Simon Fraser [no longer active]]

M10

Comment 2

[Simon Fraser [no longer active]]

M11

Comment 3

[Charles Manske]

*** Bug 11794 has been marked as a duplicate of this bug. ***

Comment 4

[Charles Manske]

Toggling off a text attribute when we have a collapsed selection doesn't work
because SetTypeInStateForProperty() isn't clearing the "typeInState" correctly.
This can be tested by placing caret in bold text and clicking on the bold
toolbar button or using Format | Clear All Styles on the menu. Both call
nsHTMLEditor::SetInlineProperty(), which calls SetTypeInStateForProperty()
when the selection is collapsed.
Steve: This is your method, so we're giving you first crack at this!

Comment 5

[buster]

SetTypeInStateForProperty is actually setting the state correctly, but
CreateStyleForInsertText isn't responding to the state properly (notice the
various "not yet implemented" messages.)  The implementation is fairly
straightforward, I'll shoot for M11.

Comment 6

[buster]

fixed for bold, italic, underline.  still looking into fonts.

Comment 7

[buster]

fixed

Comment 8

[sujay]

verified in 9/22 build..