1180572 - create attachment_storage parameter

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[:glob ✱]

remove maxlocalattachment parameter and replace it with a attachment_storage parameter with options for 'database' and 'filesystem'.  s3 support will be added in another bug.

Comment 1

[:glob ✱]

Attachment: 1180572_1.patch

- remove 'maxlocalattachment' parameter, replace with 'attachment_storage'
- create Bugzilla::Attachment::* classes and update B::Attachment to use them
- create migrate-attachments.pl script for copying and deleting attachments between storage mechanisms

Comment 2

[David Lawrence [:dkl]]

Comment on attachment 8635138 [details] [diff] [review]
1180572_1.patch

Review of attachment 8635138 [details] [diff] [review]:
-----------------------------------------------------------------

Codewise nothing stands out as suspect. I did thorough testing on moving attachments back and forth, deleting, and exercising the different backends with normal attachment operations. r=dkl

Comment 3

[:glob ✱]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   dc8e2b4..ec9b5fd  master -> master

Comment 4

[:glob ✱]

fix attachment deletion errors:

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   19cfefe..c53d646  master -> master