1180603 - Text inside text bubbles should always be aligned according to the text direction

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P2)

Description

[Bogdan Maris, Desktop QA]

Attachment: Screenshot showing the issue

Affected builds:
- latest Aurora 41.0a2
- latest Nighty 42.0a1

Affected OS`s:
- Windows 7 64-bit
- Ubuntu 14.04 32-bit
- Mac OS X 10.10

STR:
1. Start Firefox
2. Start a Conversation
3. Join the conversation from a new tab/different browser or PC
4. In the textarea write a long string 
eg:
'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Proin commodo convallis risus, in tincidunt mi ullamcorper non. Aliquam tortor nibh, feugiat ac sem sed, tristique elementum quam. Fusce mattis faucibus imperdiet. Curabitur quis enim eu nibh porttitor vulputate at pulvinar elit. Suspendisse et dolor iaculis, viverra purus quis, iaculis lectus. In gravida nibh dui, eget molestie lorem viverra quis. Nunc eleifend justo diam, vel venenatis libero porta sed. '

Expected results: The text is aligned to left for non l10n languages, for l10n I don`t know what is the expected result here.

Actual results: The text is aligned to right for the user that types (conversation window or Standalone).

Notes:
- This is not a regression, it reproduces since chat was introduced by default in Nightly.
- Screenshot showing the issue attached

Comment 1

[Marina Rodríguez [:mai]]

Attachment: 0001-Bug-1180603-Text-inside-text-bubbles-should-always-b.patch

Comment 2

[Marina Rodríguez [:mai]]

Comment on attachment 8632745 [details] [diff] [review]
0001-Bug-1180603-Text-inside-text-bubbles-should-always-b.patch

Hi, 
would you mind reviewing the patch?
Regards

Comment 3

[Mike de Boer [:mikedeboer]]

Comment on attachment 8632745 [details] [diff] [review]
0001-Bug-1180603-Text-inside-text-bubbles-should-always-b.patch

Well, excellent! LGTM :)

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/ccbfb04250cb

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ccbfb04250cb

Comment 6

[Bogdan Maris, Desktop QA]

I just tested this on latest Nightly 42.0a1 with both loop servers, the default one and 'https://loop-dev.stage.mozaws.net/v0' but I don't see this issue fixed. It looks exactly the same as before. Any ideas why?

Here is a screenshot of how it looks now:
https://dl.dropboxusercontent.com/u/109148197/Hello%20Context/Screenshot%20from%202015-08-06%2012%3A27%3A03.png

Comment 7

[Mark Banner (:standard8)]

It looks like bug 1183576 regressed this change, but I can't see why on that bug - Marina, do you know if reverting this change was intentional or not?

Comment 8

[Marina Rodríguez [:mai]]

Hi, 
the revertion was unintentional, I think it was a bad rebase of the bug 1183579 patch.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/0cd73195817b

Comment 10

[Mark Banner (:standard8)]

Ok, I've re-landed this. Thanks for catching it Bogdan.

Comment 11

[Guilherme Lima]

This landed yesterday - https://hg.mozilla.org/mozilla-central/rev/0cd73195817b

Comment 12

[Bogdan Maris, Desktop QA]

Verified as fixed in Firefox 42beta3 across platforms (Windows 7 64-bit, Mac OS X 10.10.5 and Ubuntu 14.04 32-bit).