1180739 - mach artifact install doesn't work with desktop build identifiers (macosx, win32, linux,linux64)

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[:Gijs (he/him)]

(I've not actually tried the windows/linux flavours, but I image from the error message that they don't work either)

Comment 1

[:Gijs (he/him)]

Nick, can you point me and/or other interested parties in the right direction here?

Comment 2

[Nick Alexander :nalexander [he/him]]

(In reply to :Gijs Kruitbosch from comment #1)
> Nick, can you point me and/or other interested parties in the right
> direction here?

Yes!

There are a few things needed here:

1) add an entry to the jobs listed here: https://dxr.mozilla.org/mozilla-central/source/python/mozbuild/mozbuild/artifacts.py#70

2) handle the TODO item about unpacking from different file types.  You can see that I'm assuming a zip archive (aar files are just zips with certain contents), which doesn't apply to Desktop builds.

3) find a way to extract a version identifier (build ID?  Task Cluster job id?  Start with the latter) for the artifact, and then work it into the cached path in some way, so that you can handle

build1/firefox-VERSION.tar.bz2
build2/firefox-VERSION.tar.bz2
...

Fennec doesn't have this issue, since the build ID is built into the artifact archive, like

geckolibs-BUILDID1.aar
geckolibs-BUILDID2.aar

4) you may need to parameterize the .so copying code, depending on the library types and destinations.

At this point, consider extracting an abstract Job class that encapsulates these differences.

Comment 3

[Nick Alexander :nalexander [he/him]]

This is done as of Bug 1236110 and Bug 1236111.