1180811 - Dismiss "Zoomed View" when user taps outside the zoomed area

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

After some discussion in https://bugzilla.mozilla.org/show_bug.cgi?id=1165127#c5 and some User studies we ran, I think we should implement this behaviour now.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Dominique?

Comment 2

[Dominique Vincent [:domivinc]]

I'm going to work on it.

Comment 3

[Dominique Vincent [:domivinc]]

Attachment: patch-08072015 1-Bug_1180811___Dismiss_Zoomed_View_when_user_taps_outside_the_zoomed_area__r_mcomella.patch

Just one point to take into account during your tests: if the tap occurs outside the zoomed view but on a cluster area, the zoomed view will be displayed on the new cluster area.
To close the zoomed view, the tap must be done in an area without any cluster of links.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Dominique Vincent [:domivinc] from comment #3)
> Just one point to take into account during your tests: if the tap occurs
> outside the zoomed view but on a cluster area, the zoomed view will be
> displayed on the new cluster area.
> To close the zoomed view, the tap must be done in an area without any
> cluster of links.

I wonder how intuitive this functionality would be.

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8631058 [details] [diff] [review]
patch-08072015 1-Bug_1180811___Dismiss_Zoomed_View_when_user_taps_outside_the_zoomed_area__r_mcomella.patch

Review of attachment 8631058 [details] [diff] [review]:
-----------------------------------------------------------------

Seems reasonable to me.

Comment 6

[Dominique Vincent [:domivinc]]

https://tbpl.mozilla.org/?tree=Try&rev=3083a53e5c8b

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/00d51ff47b84

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/00d51ff47b84

Comment 9

[Teodora Vermesan (:TeoVermesan)]

Verified as fixed using:
Device: LG Nexus 4 (Android 5.0)
Build: Firefox for Android 43.0a1 (2015-08-17)