All users were logged out of Bugzilla on October 13th, 2018

Dismiss "Zoomed View" when user taps outside the zoomed area

RESOLVED FIXED in Firefox 43

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: antlam, Assigned: domivinc, Mentored)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 42
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox43 verified)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
After some discussion in https://bugzilla.mozilla.org/show_bug.cgi?id=1165127#c5 and some User studies we ran, I think we should implement this behaviour now.
(Reporter)

Updated

3 years ago
Flags: needinfo?(michael.l.comella)
Flags: needinfo?(domivinc)
Dominique?
Assignee: nobody → domivinc
Mentor: michael.l.comella
Flags: needinfo?(michael.l.comella)
(Assignee)

Comment 2

3 years ago
I'm going to work on it.
Flags: needinfo?(domivinc)
(Assignee)

Comment 3

3 years ago
Created attachment 8631058 [details] [diff] [review]
patch-08072015 1-Bug_1180811___Dismiss_Zoomed_View_when_user_taps_outside_the_zoomed_area__r_mcomella.patch

Just one point to take into account during your tests: if the tap occurs outside the zoomed view but on a cluster area, the zoomed view will be displayed on the new cluster area.
To close the zoomed view, the tap must be done in an area without any cluster of links.
Attachment #8631058 - Flags: review?(michael.l.comella)
(In reply to Dominique Vincent [:domivinc] from comment #3)
> Just one point to take into account during your tests: if the tap occurs
> outside the zoomed view but on a cluster area, the zoomed view will be
> displayed on the new cluster area.
> To close the zoomed view, the tap must be done in an area without any
> cluster of links.

I wonder how intuitive this functionality would be.
Comment on attachment 8631058 [details] [diff] [review]
patch-08072015 1-Bug_1180811___Dismiss_Zoomed_View_when_user_taps_outside_the_zoomed_area__r_mcomella.patch

Review of attachment 8631058 [details] [diff] [review]:
-----------------------------------------------------------------

Seems reasonable to me.
Attachment #8631058 - Flags: review?(michael.l.comella) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/00d51ff47b84
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Verified as fixed using:
Device: LG Nexus 4 (Android 5.0)
Build: Firefox for Android 43.0a1 (2015-08-17)
status-firefox42: fixed → ---
status-firefox43: --- → verified
You need to log in before you can comment on or make changes to this bug.