1232861 - Experiment: *only* dismiss zoomed view when user taps outside of it

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

In bug 1222234 comment 19, Anthony okayed an approach to *only* dismiss the zoomed view when the user taps outside an open zoomed view. This means links are not opened, another zoomed view will not appear, and, as Anthony points out, we shouldn't pan the page.

I'm not convinced this is the best approach, hence the experiment tag. Let's get antlam a build!

Anthony, how essential is this? I'd prefer we'd spend time working on other things if the current version is acceptable. Note that zoomed view is shipping in 45 so if we act quickly, we can change the behavior in the first version that sees release.

Then again, this doesn't seem too hard (add hit target outside zoomed view and capture touch event in java to dismiss) so maybe we should just come up with a build.

bug 1180811 was a previous bug about dismissing the zoomed view when it's clicked outside.

Comment 1

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to Michael Comella (:mcomella) from comment #0)
> In bug 1222234 comment 19, Anthony okayed an approach to *only* dismiss the
> zoomed view when the user taps outside an open zoomed view. This means links
> are not opened, another zoomed view will not appear, and, as Anthony points
> out, we shouldn't pan the page.
> 
> I'm not convinced this is the best approach, hence the experiment tag. Let's
> get antlam a build!
> 
> Anthony, how essential is this? I'd prefer we'd spend time working on other
> things if the current version is acceptable. Note that zoomed view is
> shipping in 45 so if we act quickly, we can change the behavior in the first
> version that sees release.
> 
> Then again, this doesn't seem too hard (add hit target outside zoomed view
> and capture touch event in java to dismiss) so maybe we should just come up
> with a build.
> 
> bug 1180811 was a previous bug about dismissing the zoomed view when it's
> clicked outside.

Awesome! If it's not too hard, I'd like to get this UX in. 

This experience is something that I've been pushing for (for a while now) but more importantly, it helps us avoid many situations and edge cases that we seem to constantly be running into (What happens when the view is open AND 'x'?).

It also just helps us avoid confusing our users because this is visually very "modal-ly" and we normally dismiss modals when they tap outside that area.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Sorry, I dropped the ball. Anthony, still want to do this? If so, let's see if Dominique has the cycles to take a look.

Comment 3

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Yes, I think this still makes sense. It also solves a lot of common case problems with the current Zoomed View

Thanks!

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Dominique, do you have time to take a stab at this?

Comment 5

[Dominique Vincent [:domivinc]]

(In reply to Michael Comella (:mcomella) from comment #4)
> Dominique, do you have time to take a stab at this?

I made a first attempt (in ZoomedView.java and browser.js) but it doesn't work. It's probably due to the different "AppConstants.MOZ_ANDROID_APZ" tests added in browser.js. It looks like the flow of the events is different with or without the APZ change (for instance "Gesture:Scroll" is no more called in browser.js). 
It will be easier to test this experiment when all the APZ tests will be removed. With the current version of the code, we have to implement it twice, in different parts of the code. I'm not sure it's a good idea to add more "AppConstants.MOZ_ANDROID_APZ" tests just for this UX experiment.

Comment 6

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.