1181329 - [User Story] Make DataStore available to privileged homescreen apps

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Ben Francis [:benfrancis]]

In order to allow third party replaceable homescreens we need the Data Store API to be made available to third party privileged apps which identify themselves with the "homescreen" role in their manifest. This will enable access to the bookmarks and places data stores which the Gaia's built-in homescreen can access.

Eventually we would like to deprecate the data stores in favour of a more webby solution, but for the 2.5 release we need to unblock replaceable homescreens by making the DataStore available under some specific circumstances. That is apps which:
* Are of type "privileged" (have been reviewed and signed)
* Have the "homescreen" role in their manifest
* Are set as the current homescreen in Settings

Comment 1

[[:fabrice] Fabrice Desré]

fyi, here's how to check if a document is from the current homescreen:
http://mxr.mozilla.org/mozilla-central/source/dom/apps/Webapps.jsm?rev=f848e6877ca4#1301

Comment 2

[Andrea Marchesini [:baku]]

Attachment: ds.patch

Comment 3

[[:fabrice] Fabrice Desré]

Comment on attachment 8630729 [details] [diff] [review]
ds.patch

Review of attachment 8630729 [details] [diff] [review]:
-----------------------------------------------------------------

We should test that, but that can go in a followup.

Comment 4

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3efa3b65e755

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3efa3b65e755

Comment 6

[Ben Francis [:benfrancis]]

Thanks Andrea, that was super fast!

Comment 7

[Chris Lord [:cwiiis]]

I guess this page needs changing? https://developer.mozilla.org/en-US/docs/Web/API/DataStore

Comment 8

[GitHub Autolander Bot]

Attachment: [gaia] Cwiiis:bug1198212-fix-homescreen-intermittents > mozilla-b2g:master

Comment 9

[Chris Lord [:cwiiis]]

Comment on attachment 8653422 [details] [review]
[gaia] Cwiiis:bug1198212-fix-homescreen-intermittents > mozilla-b2g:master

Wrong bug...

Comment 10

[Chris Mills [:cmills]]

I have written some details on what a 3rd party manifest would need to include here:

https://developer.mozilla.org/en-US/docs/Web/API/Data_Store_API/Using_the_Data_Store_API#Privileged_homescreen_apps

I've also added a note at the top of 

https://developer.mozilla.org/en-US/docs/Web/API/DataStore

A quick tech review would be great; thanks!