Closed Bug 1198212 Opened 9 years ago Closed 9 years ago

TEST-UNEXPECTED-FAIL | apps/homescreen/test/marionette/app_packaged_resume_test.js | Homescreen - Packaged App Resuming Downloads failed state then retry and launch

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Homescreen
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-master fixed)

Status:
RESOLVED FIXED
Milestone:
FxOS-S6 (04Sep)
Tracking Flags:
Tracking Status
b2g-master --- fixed

People

(Reporter: apastor, Assigned: cwiiis)

References

Details

(Keywords: intermittent-failure, Whiteboard: [systemsfe])

Attachments

(1 file)

[gaia] Cwiiis:bug1198212-fix-homescreen-intermittents > mozilla-b2g:master
46 bytes, text/x-github-pull-request
apastor
: review+
Details | Review
log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=4364923 repository: fx-team start_time: 2015-08-24T23:36:21 who: nigelbabu[at]gmail[dot]com machine: unknown buildname: non-buildbot mulet-linux64 test [TC] Mulet Gaia JS Integration Test revision: b9ae6b3addaf TEST-UNEXPECTED-FAIL | apps/homescreen/test/marionette/app_packaged_resume_test.js | Homescreen - Packaged App Resuming Downloads failed state then retry and launch make: *** [test-integration-test] Error 1 Return code: 2 Tests exited with return code 2: harness failures # TBPL FAILURE #
See Also: → 1119103
Hey Chris, is this error coming from the new homescreen Gij tests? Thanks!
Flags: needinfo?(chrislord.net)
Whiteboard: [systemsfe]
I'll take this.
Assignee: nobody → chrislord.net
Blocks: new-homescreen
Component: Gaia::System → Gaia::Homescreen
Flags: needinfo?(chrislord.net)
OS: Mac OS X → Gonk (Firefox OS)
Hardware: x86 → All
Comment on attachment 8653423 [details] [review] [gaia] Cwiiis:bug1198212-fix-homescreen-intermittents > mozilla-b2g:master This is looking good - I've triggered a few more Gij8's (which I think contains at least one of the affected tests) to make sure, but I think this can be reviewed now. It certainly fixed things for me locally (where oddly, they were almost consistently failing - obviously it wasn't like that when I checked it in initially :/)
Attachment #8653423 - Flags: review?(apastor)
Gij8 looking good, also retriggered 7 and 9 a few times which also have affected homescreen tests.
Comment on attachment 8653423 [details] [review] [gaia] Cwiiis:bug1198212-fix-homescreen-intermittents > mozilla-b2g:master Looks good to me. It would be nice to wait an specific condition instead of an amount of time, but feel free to land it as it is if you don't find it. At least it will improve things! Thanks for taking this.
Attachment #8653423 - Flags: review?(apastor) → review+
(In reply to Alberto Pastor [:albertopq] from comment #77) > Comment on attachment 8653423 [details] [review] > [gaia] Cwiiis:bug1198212-fix-homescreen-intermittents > mozilla-b2g:master > > Looks good to me. It would be nice to wait an specific condition instead of > an amount of time, but feel free to land it as it is if you don't find it. > At least it will improve things! Thanks for taking this. mm, I wanted that loop to wait X amount of time to see if display=none was removed before retrying, but that ended up being so tricky that it may well just wait that short amount of time, as it'd have to wait for the button to become visible after the animation anyway. If this shows up again at some point, I'll do better :)
Status: NEW → ASSIGNED
Will check in as-is for now. New homescreen is doing reasonably well for not having arbitrary periods of waiting vs. old home-screen, but I'll try to improve this in the future.
Keywords: checkin-needed
Master: https://github.com/mozilla-b2g/gaia/commit/db091f2bffefd44d5bcad362a7271e234b1b89ea
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-b2g-master: --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S6 (04Sep)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: