118141 - can't drag bookmarks from a personal toolbar folders

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, enhancement)

Description

[Tim Powell]

Using the 20011228 build it is possible to rearrange bookmarks using drag and 
drop in the bookmarks menu activated from the bookmarks button. Folders on the 
personal toolbar should also be able to do this. Users do not expect a 
difference in behavior between the bookmarks menu and personal toolbar folder 
menus.

To reproduce:
1) Create a folder on the personal toolbar and add some bookmarks to it
2) Open the folder by clicking on it on the personal toolbar
3) Try to re-order a bookmark by dragging it to a new location and dropping it.

Expected:
While dragging, a bar will show up indicating where the bookmark will be placed 
and when dropped the bookmark will show up in the new location.

Actual:
No placement bar and no rearranging is possible with drag and drop.

For comparison, open the bookmark menu by clicking the bookmarks butons on the 
personal toolbar. Drag and drop to arrange bookmarks works here.

Note that the bookmarks menu has a problem that it does not open subfolders 
greater than 2 deep when dragging and dropping. I believe that this is bug 
100479 or bug 105263.

I couldn't find a duplicate of this bug so I went ahead and logged it. It is 
similar to bug 50505.

Comment 1

[Tim Powell]

Reassigning to Paul Chen since he appears to be working on related bookmarks 
bugs.

Comment 2

[Scott Tran (Wildcard)]

Re-Assigning to Ben

Comment 3

[Martin Macok]

Rearranging bookmarks with drag&drop is very messy in m097 (on Red Hat 7.2
Linux) at all. It moves to different positions than expected (where the mouse
and horizontal black position indicator) or not move at all etc...

Comment 4

[Christophe Combelles]

On 1.0 RC1, When dragging a bookmark from one position to another, a small bar
appears : I have discovered that this small bar can have two different positions
when it is between two bookmarks. The two positions are separated by only one
pixel. 
So when you release the mouse to drop the bookmark, the new position depends on
this single pixel.
If you chose the left one, the bookmark is put at the correct position.
But if you chose the right, the bookmark is put at the right of the right bookmark.

Comment 5

[Pierre Chanial]

taking

Comment 6

[Pierre Chanial]

*** Bug 139472 has been marked as a duplicate of this bug. ***

Comment 7

[Jesse Ruderman]

Pierre, does your patch also fix bug 50505 (drag from bookmarks menu on menu
bar), or does it only add allow you to drag from personal toolbar menus?

Comment 8

[Pierre Chanial]

Jesse, yes it does: bookmarks in the bookmark menu, personal toolbar, menus and
submenus are handled by the same observer.

Comment 9

[Pierre Chanial]

Jesse, sorry, I misunderstood: no my patch only apply to the personal toolbar,
not the menu bar.

Comment 10

[Pierre Chanial]

*** Bug 137508 has been marked as a duplicate of this bug. ***

Comment 11

[Pierre Chanial]

fixed under windows by the checkin of bug 139471
on linux, we have event handling problems unrelated to the implementation of
this feature.